MONAI
MONAI copied to clipboard
Project-MONAI
5269 5291 Update PyTorch base docker to 22.09
Fixes #5269 Fixes #5291 .
Description
This PR updated the PyTorch base docker to 22.09.
Types of changes
- [x] Non-breaking change (fix or new feature that would not break existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running
./runtests.sh -f -u --net --coverage. - [ ] Quick tests passed locally by running
./runtests.sh --quick --unittests --disttests. - [x] In-line docstrings updated.
- [ ] Documentation updated, tested
make htmlcommand in thedocs/folder.
Thanks, could you help address #5291 while merging this...
Hi @wyli ,
I think the issue #5291 is not related to docker 22.09, should we merge this PR first?
Thanks.
Sure, I don't think it's a blocker, if we use torchrun and the import will be within each process. Lets follow @YanxuanLiu's process to upgrade these...
Sure, I don't think it's a blocker, if we use torchrun and the import will be within each process. Lets follow @YanxuanLiu's process to upgrade these... @wyli @Nic-Ma
I think it's a blocker. None of my 3D segmentation code is working in that container. For many people it'll be the same ( a combination of monai=1.0.0 and 22.09).
Also I don't use torchrun (since we initialize a shared cash in master process). Other people may not like torchrun for other reasons.
ok, this is the only place we import cv2:
https://github.com/Project-MONAI/MONAI/blob/f49cc963179d1ca678f6ca2d05918157959bd9b3/monai/data/video_dataset.py#L23-L28
we can make it lazy import in: https://github.com/Project-MONAI/MONAI/blob/4ad790cc5f6022a92e0585c34f2f50fb6fa7fd62/monai/init.py#L42
what do you think @Nic-Ma?
minor changes included here based on this PR https://github.com/Project-MONAI/MONAI/pull/5278/commits/1b2d402816ff26afd553c6744832cfbd572ebb60