MONAI icon indicating copy to clipboard operation
MONAI copied to clipboard

4563 Enhance the stats information of workflows

Open Nic-Ma opened this issue 1 year ago • 11 comments

Fixes #4563 .

Description

This PR enhanced the stats information of trainer and evaluator workflows.

Status

Ready

Types of changes

  • [x] Non-breaking change (fix or new feature that would not break existing functionality).
  • [ ] Breaking change (fix or new feature that would cause existing functionality to change).
  • [ ] New tests added to cover the changes.
  • [ ] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • [ ] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • [ ] In-line docstrings updated.
  • [ ] Documentation updated, tested make html command in the docs/ folder.

Nic-Ma avatar Aug 10 '22 07:08 Nic-Ma

/black

Nic-Ma avatar Aug 10 '22 09:08 Nic-Ma

/build

Nic-Ma avatar Aug 10 '22 09:08 Nic-Ma

/black

Nic-Ma avatar Aug 11 '22 03:08 Nic-Ma

/build

Nic-Ma avatar Aug 11 '22 03:08 Nic-Ma

/build

Nic-Ma avatar Aug 11 '22 03:08 Nic-Ma

/black

Nic-Ma avatar Aug 11 '22 13:08 Nic-Ma

/build

Nic-Ma avatar Aug 11 '22 13:08 Nic-Ma

/build

Nic-Ma avatar Aug 11 '22 14:08 Nic-Ma

/build

Nic-Ma avatar Aug 12 '22 04:08 Nic-Ma

/build

Nic-Ma avatar Aug 12 '22 13:08 Nic-Ma

Hi @holgerroth ,

Thanks for your review and test. I see the error message is in NVFlare, could you please help provide more information on MONAI side?

Thanks.

Nic-Ma avatar Aug 13 '22 09:08 Nic-Ma

The issue came from using an old UNet style config in the NVFlare configuration.

>>> net = UNet(
...     dimensions=2,
...     in_channels=1,
...     out_channels=2,
...     channels=(16, 32, 64, 128, 256),
...     strides=(2, 2, 2, 2),
...     num_res_units=2,
...     norm="batch"
... )
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: __init__() missing 1 required positional argument: 'spatial_dims'

Changing dimensions to spatial_dims solves the issue.

holgerroth avatar Aug 15 '22 14:08 holgerroth

/build

wyli avatar Aug 15 '22 14:08 wyli