MONAI icon indicating copy to clipboard operation
MONAI copied to clipboard

extensions of the surface-based metric

Open wyli opened this issue 2 years ago • 9 comments

Is your feature request related to a problem? Please describe. Follow up of https://github.com/Project-MONAI/MONAI/pull/4050, this is a feature request to extend the surface-based metric module for 3D, with the support of more detailed quantizations when computing local surface lengths/areas (such as the computation proposed in https://github.com/deepmind/surface-distance).

cc @SilviaSeidlitz

wyli avatar Apr 11 '22 12:04 wyli

Hausdorff distance and Average surface distance in Monai are already implemented using the deep mind library you are referring to, what exactly is not present that you need?

You can also lok into some fast approximation that I am now developing in

https://github.com/Project-MONAI/MONAI/pull/4078

this can give potentially the performant approximations of the quantities you are requesting

jakubMitura14 avatar Apr 13 '22 18:04 jakubMitura14

what exactly is not present that you need?

please see https://github.com/Project-MONAI/MONAI/pull/4050#discussion_r846827002

wyli avatar Apr 13 '22 18:04 wyli

ok now I get it, I will consider wheather I can contribute to it !

jakubMitura14 avatar Apr 13 '22 18:04 jakubMitura14

Hi can Average surface distance be considered same as Average Hausdorff distance ? Because I cant see Average Hausdorff distance implementation in monai. Thanks for reply

hreso110100 avatar Jun 12 '22 14:06 hreso110100

Hello I can not say wheather they are mathemathically the same as my mathemathical skills are not sufficient - I suppose not exactly, but I ran some statistical experiments suggesting that they are closely correlated - correlation around 0.9 and very low p values.

jakubMitura14 avatar Jun 12 '22 14:06 jakubMitura14

Maybe @wyli can confirm this ?

hreso110100 avatar Jun 23 '22 13:06 hreso110100

no they are different distances @hreso110100

wyli avatar Jun 23 '22 13:06 wyli

And is there some plan to add also this metric ?

hreso110100 avatar Jun 26 '22 13:06 hreso110100

Here is working Morphological algorithm (pytorch extension - not MONAI) https://github.com/jakubMitura14/Hausdorff_morphological

Hovewer this is fast morphological approximation - quite accurate and having very good performance, still not exact, also it can be considered rather research than production software

To be honest recently I got a new job and was unable to spend time debugging MONAI pull request here is the pull request to MONAI - it is not working, would you like to contribute in debugging :) https://github.com/Project-MONAI/MONAI/pull/4078

jakubMitura14 avatar Jun 26 '22 15:06 jakubMitura14