HAMi icon indicating copy to clipboard operation
HAMi copied to clipboard

setup multi-arch build

Open morlay opened this issue 1 year ago • 5 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

to build multi arch images with amd64/arm64

Which issue(s) this PR fixes: no

Special notes for your reviewer:

Does this PR introduce a user-facing change?: no

morlay avatar May 06 '24 04:05 morlay

Hi @morlay, Thanks for your pull request! If the PR is ready, use the /auto-cc command to assign Reviewer to Review. We will review it shortly.

Details

Instructions for interacting with me using comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

github-actions[bot] avatar May 06 '24 04:05 github-actions[bot]

Known Issue:

lib/mlu/* is x86-64 only. but now could make vgpu multi-arch supported first.

$ file lib/mlu/*
lib/mlu/cntopo:          ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=f4e84ebeefefc76c0dbf925d5b28b3c2318f9342, stripped
lib/mlu/libcndev.so:     ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=4e4a1717580ce285e50565322b7a87cf3d3d1422, stripped
lib/mlu/smlu-containerd: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=e3ea08302634487ef73ba64cc55e801d1a085920, with debug_info, not stripped

morlay avatar May 06 '24 04:05 morlay

/auto-cc

morlay avatar May 06 '24 06:05 morlay

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: morlay Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

hami-robott[bot] avatar May 31 '24 10:05 hami-robott[bot]

Is there anything wrong with this pr now?

CoderTH avatar Jun 06 '24 03:06 CoderTH

Currently, HAMi images already support multiple architectures.

wawa0210 avatar Oct 12 '24 10:10 wawa0210