books-api icon indicating copy to clipboard operation
books-api copied to clipboard

Filter by language

Open knjk04 opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? If so, please describe. A user may only want to see their books in their chosen language (e.g. Spanish). Currently, we'd show all books that satisfy the query, regardless of the language.

Describe the solution you'd like For every GraphQL query, we should have an optional language argument.

Possible approaches:

  • filter the result set
  • define a custom query

Additional context

  • Be sure to read the contributing guidelines first!
  • Discuss your implementation approach with us before we assign you to it
  • Provide us with an estimate on how long you think it will take you to complete
  • Branch from main and set main as the destination branch in your pull request

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

knjk04 avatar Mar 20 '22 12:03 knjk04

Hello. Could I do this task? I have read the contributing guidelines. I think it will take about one week. My approach would be to write the appropriate query and the corresponding data fetcher.

gstamatiadis avatar Apr 08 '22 07:04 gstamatiadis

Hey Karan @knjk04,

I can take this up. Should be a straightforward one.

Approach:

  1. Request would contain an optional 'lang' param.
  2. I feel, filtering the result set is a better option since a where clause in a query seems unnecessary.

Please let me know if this looks okay! Looking forward to your reply.

acyuta1 avatar May 30 '22 11:05 acyuta1