book-project icon indicating copy to clipboard operation
book-project copied to clipboard

Published 20 hours ago • verified publisher icon Project-Books

Redesign navigation bar

Open knjk04 opened this issue 3 years ago • 9 comments

Describe the solution you'd like

Our current navigation bar:

image

Desired:

image

We would like our navigation bar to look like the image above. This includes:

  • Showing a rectangular grey box (with rounded corners) around the currently selected item (page)
  • Change the text colour from black to grey
  • Replace the grey shadow line with the non-shadow line
  • Make the logout button text red

Additional context

  • Be sure to read the contributing guidelines first!
  • Discuss your implementation approach with us before we assign you to it
  • Provide us with an estimate on how long you think it will take you to complete
  • Branch from main and set main as the destination branch in your pull request

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

knjk04 avatar Jan 28 '22 10:01 knjk04

Can I pick up this issue?

JustinStrik avatar Jan 28 '22 22:01 JustinStrik

Hi @JustinStrik, thanks for your interest. How long do you think it will take you to complete this?

knjk04 avatar Jan 29 '22 06:01 knjk04

Is this issue still open? Can I contribute?

mayanksony avatar Feb 23 '22 05:02 mayanksony

Hi @mayanksony, this issue is still open. Thanks for offering to work on this! I'll assign you to it

knjk04 avatar Feb 23 '22 19:02 knjk04

Hi @mayanksony, how are you getting on with this?

knjk04 avatar Mar 07 '22 18:03 knjk04

Hi @mayanksony, we will unassign this from you as we have not heard back

knjk04 avatar Mar 14 '22 19:03 knjk04

Hi, is this issue still open? Can I try to contribute?

Melodyyueqi avatar May 02 '22 03:05 Melodyyueqi

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 01 '22 05:07 stale[bot]

Hi,

I'd like to take this issue up, to confirm, all that is left is:

  • Add a (curved edged) box around the active item
  • Change the text from black to grey
  • Change the grey shadow line to the non-shadow line

I believe that is all left to do, after a previous PR changed the logout button colour?

EDIT: I see that it was a matter of a different issue being closed, rather than implemented. I will still be able to change the colour of the log out button.

tom-burrows avatar Jul 03 '22 17:07 tom-burrows

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 01 '22 19:09 stale[bot]