dexterous icon indicating copy to clipboard operation
dexterous copied to clipboard

Published 20 hours ago • verified publisher icon Project-ARTist

LogA: Make trikita.log invisible to ARTistGUI

Open partipan-dot opened this issue 6 years ago • 2 comments

The logging methods in LogA respect the set log level and ARTistGuishould depend only on LogA. It shouldn't be able to call trikita.log directly.

This change depends on: Project-ARTist/ArtistGui#62

partipan-dot avatar Jun 06 '18 11:06 partipan-dot

I am fine with this, seems like a good idea to enforce the usage of the LogA API. In terms of ordering: I assume that we can accept this PR without breaking anything, then reference this in ArtistGui's dexterous submodule, update https://github.com/Project-ARTist/ArtistGui/pull/62 correspondingly and then accept that PR as well?

schrnz avatar Jun 06 '18 20:06 schrnz

No, this change breaks ARTistGUI directly after merging this PR. ARTistGUI calls logging methods from trikita.log in several places. Project-ARTist/ArtistGui#62 replaces all calls to methods from trikita.log and android.util.log. After merging this PR the CI PR test for Project-ARTist/ArtistGui#62 will pass. It can't find the submodule commit hash (in this PR) currently.

partipan-dot avatar Jun 06 '18 21:06 partipan-dot