sidekick-feedback icon indicating copy to clipboard operation
sidekick-feedback copied to clipboard

iOS Properties tab Should Correctly Request/Validate Version and Build Numbers.

Open EdJones opened this issue 6 years ago • 0 comments

Please, provide the details below:

SideKick has app version and build version backwards. Also, it incorrectly validates for a build.

Did you verify whether this issue has already been reported here?

_Yes

Tell us about the problem

Basically, we want to differentiate iOS build from versions (a new build requires no AppStore review for testing, but a new version does).

SideKick gets this wrong in two ways:

  1. It has them backwards. Apple's use of CFBundleShortVersionString vs CFBundleVersion is explained here. (Note that accepted answer does not fully explain Apple's use/validation algorith. Read downward.) The former is the "version" number, the latter the "build" number. SideKick reverses these.

  2. It does not validate the build correctly. Currently both fields require a X.X.X format. However, if you manually change (in Info.plist) CFBundleVersion to something like 0.5.5.1, Apple will accept it. (And allow testing without a new review).

Which platform(s) does the issue occur on?

_iOS
_Windows

Provide the following version numbers that the issue occurs with:

  • NativeScript Sidekick: 1.19.2 and earlier
  • NativeScript CLI:
  • CLI extension nativescript-cloud:
  • CLI extension nativescript-starter-kits:

How to obtain this information is explained in the Gather information about your development environment section.

Tell us how to recreate the issue in as much detail as possible

  1. Change CFBundleVersion in Info.Plist tosomething like 1.2.2.1 or N1234
  2. Start the application ..
  3. Click 'Properties' tab, then 'iOS'.
  4. Observe where the change shows up.
  5. Change to 1.2.2.2 and note that it is not accepted, tho Apple will accept that.

Does this issue happen every time?

_Yes

Send the client logs

N/A

EdJones avatar Nov 24 '19 15:11 EdJones