chameleon icon indicating copy to clipboard operation
chameleon copied to clipboard

Published 20 hours ago • verified publisher icon ProfessionalWiki

Show edit window and buttons below changes when using PageForms

Open WouterRademaker opened this issue 1 year ago • 6 comments

Should solve #319. @ckapop found the issue that was causing this error and a solution. The changes were made suitable for and tested on Chameleon 4.3.0 by @WouterRademaker.

WouterRademaker avatar Dec 04 '23 08:12 WouterRademaker

It fails the PHPUnit tests, but works. What must be done to fix the tests?

WouterRademaker avatar Dec 05 '23 09:12 WouterRademaker

Any thoughts, @malberts ?

WouterRademaker avatar May 04 '24 14:05 WouterRademaker

Can you rebase this on the latest master? I don't remember if the tests failed because of the code change, or because of some other unrelated CI issue.

However, I still need to look at this. Besides some code style issues (indents), I would like to investigate if this change can happen in a way that does not repeat that same code in all the components.

malberts avatar Jul 31 '24 16:07 malberts

As far as I understood it, it was code change, because as far as I remembered it, the error messages were about the ‘getHtml’ function in the PHPUnit tests. I don't know if all these changes are necessary, because after yet another round of tests, I just changed it everywhere.

WouterRademaker avatar Jul 31 '24 16:07 WouterRademaker

I 'm testing the changes now on a chameleon version 4.4.1. No problems yet. https://nl.scoutwiki.org/

WouterRademaker avatar Aug 05 '24 12:08 WouterRademaker