Maps icon indicating copy to clipboard operation
Maps copied to clipboard

Use user from request context

Open prudloff-insite opened this issue 7 months ago • 1 comments

This fixes #758 for us but it might not be the correct solution.

I find it a bit strange that Parser::getUserIdentity() does not check if Parser::getOptions() returns null before trying to use its result. (The documentation of Parser::getOptions() acknowledges that it can return null.)

prudloff-insite avatar Nov 21 '23 09:11 prudloff-insite

I'm not sure either that your change is correct. It seems safer to get the user from the Parser object rather than via a global.

JeroenDeDauw avatar Nov 21 '23 13:11 JeroenDeDauw