bazel-latex icon indicating copy to clipboard operation
bazel-latex copied to clipboard

Fix long file names

Open Kernald opened this issue 4 years ago • 4 comments

latexrun doesn't properly parse LaTeX's output when the filename doesn't fit in a single line - see https://github.com/aclements/latexrun/issues/19. This forces it to use ~MAX_INT as a max line length, effectively leaving the line-wrapping job up to the terminal (which should be its responsibility, not LaTeX's), and works around this issue.~ 480 as a max line length, anything significantly longer seems to break something with //packages:glossaries-extra

Fixes #50

Kernald avatar Aug 03 '21 04:08 Kernald

This surprisingly makes //packages:glossaries-extra_glossaries-extra_test flaky (it sometimes times out) - both on CI and locally. Maybe a smaller max line length (e.g. 200, something still significantly longer than the current 80) would be a good compromise?

Edit: after a bit of fiddling, 480 seems to be working fine and is hopefully long enough.

Kernald avatar Aug 03 '21 04:08 Kernald

Looks like 480, despite working >10 times locally, is still not working 100% of the time for this test. Not sure what's wrong...

Kernald avatar Aug 03 '21 06:08 Kernald

I actually just got the same issue with 80, so this is unlikely to be related - looks like there's an issue with this test.

Kernald avatar Aug 03 '21 07:08 Kernald

@patbro Did you observe any issues with //packages:glossaries-extra in other PRs? This one seems to work fine locally, I vaguely remember seeing it fail with 80 as a max line length, I'm not too sure why the CI is sometimes timing out on //packages:glossaries-extra.

Kernald avatar Aug 11 '22 10:08 Kernald

@patbro Did you observe any issues with //packages:glossaries-extra in other PRs? This one seems to work fine locally, I vaguely remember seeing it fail with 80 as a max line length, I'm not too sure why the CI is sometimes timing out on //packages:glossaries-extra.

I don't recall any issues with that package to be honest. But maybe my memory fills in the blanks here as well...

Maybe this is a Cirrus CI thing? Which might be solved when switching.

patbro avatar Sep 29 '22 20:09 patbro

This should probably be fixed by applying https://github.com/aclements/latexrun/pull/52 instead.

Kernald avatar Oct 10 '22 04:10 Kernald

Closing in favour of #98

Kernald avatar Oct 20 '22 04:10 Kernald