DiskImagery64 icon indicating copy to clipboard operation
DiskImagery64 copied to clipboard

Compile fails on Ventura

Open DannyCork opened this issue 1 year ago • 1 comments

make fails on Ventura same failures as https://github.com/ProbablyNotArtyom/DiskImagery64/issues/4

netdrivedevice.cpp:218:5: error: unknown type name 'QRegExp'
    QRegExp globPat(glob, Qt::CaseSensitive, QRegExp::Wildcard);
    ^
netdrivedevice.cpp:218:46: error: use of undeclared identifier 'QRegExp'
    QRegExp globPat(glob, Qt::CaseSensitive, QRegExp::Wildcard);
                                             ^
netdrivedevice.cpp:301:15: error: no member named 'sprintf' in 'QString'; did you mean 'asprintf'?
    m_message.sprintf("%02d,%s,00,00", msg, txt);
              ^~~~~~~
              asprintf
/usr/local/lib/QtCore.framework/Headers/qstring.h:555:20: note: 'asprintf' declared here
    static QString asprintf(const char *format, ...) Q_ATTRIBUTE_FORMAT_PRINTF(1, 2);
                   ^
1 warning and 3 errors generated.

DannyCork avatar Apr 05 '23 11:04 DannyCork

So the QRegExp class is deprecated in Qt 6. Please use QRegularExpression instead.

That will address the first 2 errors.

To fix the 3rd error, use a asprintf(), instead of sprintf()

DannyCork avatar Apr 05 '23 11:04 DannyCork