Dean Sofer

Results 242 comments of Dean Sofer

Oh yeah, to explain some stuff: - [I lumped together the prepend, append, before, after and replace logic since it's identical](https://github.com/cgross/grunt-dom-munger/pull/20/files#diff-658dcb095b4114ea9df81030b2a0bb46R109) - I changed the order to put non-destructive ops...

Huzzah! I broke everything apparently... god dammit.

Okay fixed my errors, I forgot to accomodate for the path option. However after reviewing your `expected/order.html` I realized what you had in mind when you put read first and...

I'm aware separate PR's would be better, but you didn't seem to be doing anything about those other PR's lol. Yes. I need to make more tests. Tests in this...

I _REALLY_ feel that remove should be absolutely last. This way, I can read it, and then do an after/before on it, and then finally remove it.

@jamesspencer I'm curious what the filter function you're using is.

Yeah. I would just change the property to callback. You also could improve performance by simply doing an if-set check instead of declaring a noop.

Actually. It would make sense if it worked as both a cleanup AND filter. Such as if you return 'false' it doesn't get added to the collection.

Would this have a similar effect for global variables such as `process`? I'm seeing a [similar bug](https://github.com/parcel-bundler/parcel/issues/5714)

Alternatively, I might propose passing the toState and params instead of the $location object, or just the state name.