BrianChen
BrianChen
Hi @puneethps, can you provide the configuration of upstreams(the health check related fields, the targets of upstream, etc), and the the steps of how you reproduced this(how you disable target,...
Hi @oowl , Do you have any idea of this issue? Or is there anyone else we can ask for more discussion?
> when we execute the evaluation on a set of very large routes, there will be lots of unnecessary predicates executed and CPU cycles wasted. I agreed with this idea....
> However I can also not define "general case" properly as different people may have different ideas, so I'm merely just based on the fact that HTTP protocol supports more...
Hi @namanjain98 , Can you provide more information? which includes your deployment method, configurations, steps-to-reduce, error logs, etc.
> @ADD-SP thanks. I've opened PR #13696 Hi @t-yuki , I have some comments on https://github.com/Kong/kong/pull/13696, please review it in your convenience, that would help us merge the PR faster.
> @ProBrian Excuse me, I'm unable to find your comments in #13696 . Sorry I forgot to submit the review, please check again, thanks. @t-yuki
Local benchmark result attached (MacOS M3 chip with 36GB mem), comparing with PR branch and main branch ``` Running benches/build.rs (target/release/deps/build-3f0a7ade35c0c7a4) New: Build Router time: [3.0939 ms 3.1021 ms 3.1114...
@dndx @ADD-SP Are there new comments on this PR?
> Please resolve conflicts Conflicts caused due to the revert introduced by https://github.com/Kong/atc-router/pull/284, we should figure out if that reverted change will be committed back after the investigation of performance.