Implement data validation

[cosmopockets]

Could we add some data validation functions such as, make upper case, make lower case, get random double, get random int?

[mrKappen]

I am on it!

[alxmjo]

@mrKappen Great! Also, if you're new to the repo and want to get your feet wet, a great way to do that is to migrate an algorithm to the new organization scheme, à la #201 and #202. Let me know if you have any questions.

[alxmjo]

This also requires some thought as to what our goals would be regarding validation and how we would want to implement it in the project.

[beardbytes]

I am interested and new to open source

[alxmjo]

Great! Have a look at PR #209. A lot of the work is already done but it was closed automatically a while ago (there were merge issues that were never sorted out).

[beardbytes]

Alright ! I can't find the file .

[alxmjo]

Alright ! I can't find the file .

Try this: https://github.com/ProAlgos/ProAlgos-Cpp/pull/209/commits#diff-264aaf8546723aaccf7ce2e80d46ae3f

[beardbytes]

Alright ! I can't find the file .

Try this: https://github.com/ProAlgos/ProAlgos-Cpp/pull/209/commits#diff-264aaf8546723aaccf7ce2e80d46ae3f

Okay ! I am looking where the commit conflicts are present .

[alxmjo]

Might be easiest to just add the file from scratch rather than trying to manage conflicts. I think the folder organization is good, though. include/utils/data_validation.hpp. I think it would be better to separate the random number generation into a different file. And of course we'll want to add unit tests for anything we add.

[beardbytes]

Okay . So , just to be clear . I have to make a new file in the include/utils directory . And I have to add data validation functions in this file along with unit tests !

[alxmjo]

Yep!

• [ ] Create a new file under include/utils called data_conversion.hpp (I think this title is a better reflection of the fact that we're converting cases of characters – we could add other data conversion functions later).
• [ ] In that file add two functions: make_upper_case() and make_lower_case(). The random number generation can go in a different file later on.
• [ ] Add unit tests for these functions under test/utils in a file called data_conversion.cpp.
• [ ] If you're having trouble figuring out what the tests should look like, look at other testing files to get an idea how they work.

Let me know if you have any questions. 🙂

[beardbytes]

Okay..Thanks for the explanation !

[stale[bot]]

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

[subhadeep1912]

I would like to know whether I can still contribute??

[alxmjo]

I would like to know whether I can still contribute??

Definitely. Just reference this issue in your PR.

[0xwal]

Opened a PR for upper/lower case ^ 🥳 and hopefully it closes this issue unless if random int/double still required : ) but I think they are different problems random != conversion 🤔

[0xwal]

@alxmjo Sorry for the mention. Please can you review my pull request, I would appreciate your feedback. Thank you.

[alxmjo]

Sorry it's taken me a bit, but I've added this to my to-do list. Hopefully by Saturday.

On Sun, Jan 24, 2021 at 7:25 PM Waleed Alharbi [email protected] wrote:

@alxmjo https://github.com/alxmjo Sorry for the mention. Please can you review my pull request, I would appreciate your feedback. Thank you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ProAlgos/ProAlgos-Cpp/issues/99#issuecomment-766367331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUKKX7JBBOFMC42X2RTL3S3Q3UZANCNFSM4DXW6OHA .

[rohithv999]

I am interested in contributing to this issue. Also, I am new to open source.

[ParthSaboo007]

Hi @alxmjo I am interested in contributing to this repo as my first PR.