Privacy manager not deleting all browsing data (problem reproduced)

[ghost]

Hi, sorry for reopening this issue so late, i never check github in time, and when i do, the website never gives me a notification.

I managed to reproduce the problem here : https://www.youtube.com/watch?v=bGTxFS9OQH4 the entry is deleted from chrome correctly, but it still appear as a previously accessed URL / search result.

here is a full list of all my installed addons : https://i.imgur.com/zKU6zIL.png (none of them should create a conflict with Privacy Manager as far as i can tell.) extension's settings : https://i.imgur.com/jxqPxBG.png Using : Chromium | 87.0.4280.67 (Developer Build) (64-bit)

EDIT: i just deleted all web browsing data from chrome itself, and when doing it manually, it also removes all traces of my old URLs like the extension should be doing. the problem does not occur 100% of the time, but a close 95% i think.

EDIT 2: cookies not being cleared properly after browser restart : https://i.imgur.com/MoHCd7G.png

[Manvel]

Thanks @Gomam0n-afk for your update.

EDIT: i just deleted all web browsing data from chrome itself, and when doing it manually, it also removes all traces of my old URLs like the extension should be doing. the problem does not occur 100% of the time, but a close 95% i think.

I can confirm that I was able to reproduce your issue using Chromium omnibox. It's quite strange that deleting data manually from Chrome and using chrome.browsingData API for deleting all available browsing data provide different results, it means that the suggestions for Previous URLs, are not taken only from the History and When data is removed manually an additional data flush is, though I'm not sure if Chrome provides API for that.

I'll try following up creating chromium bug to figure out why it's not possible to delete Omnibox Previous-URLs suggestions using Chrome API and if there is a possibility for extension developers to provide such functionality.

EDIT 2: cookies not being cleared properly after browser restart : https://i.imgur.com/MoHCd7G.png

I wasn't able to reproduce this, can you please try disabling your other extensions and trying again? Please let me know the results.

[ghost]

Thanks @Gomam0n-afk for your update.

EDIT: i just deleted all web browsing data from chrome itself, and when doing it manually, it also removes all traces of my old URLs like the extension should be doing. the problem does not occur 100% of the time, but a close 95% i think.

I can confirm that I was able to reproduce your issue using Chromium omnibox. It's quite strange that deleting data manually from Chrome and using chrome.browsingData API for deleting all available browsing data provide different results, it means that the suggestions for Previous URLs, are not taken only from the History and When data is removed manually an additional data flush is, though I'm not sure if Chrome provides API for that.

I'll try following up creating chromium bug to figure out why it's not possible to delete Omnibox Previous-URLs suggestions using Chrome API and if there is a possibility for extension developers to provide such functionality.

EDIT 2: cookies not being cleared properly after browser restart : https://i.imgur.com/MoHCd7G.png

I wasn't able to reproduce this, can you please try disabling your other extensions and trying again? Please let me know the results.

here are the state of cookies and site data after disabling all addons (except privacy manager) then restarting : https://i.imgur.com/wWkHAT8.png

Only 1 cookie remains for some reason, the URLs i previously went to were also harder to find, i only could find youtube and github once, which means some extension may be stopping privacy manager from deleting all the data ? i'm going to try once again, then edit the reply with my results

EDIT: i visited a couple of websites with the addons on, then disabled them then restarted my browser, and all the URLs i previously visited were still there. but i found out that restarting the browser twice does fully clean it, leaving only cached images (which i still would want gone though).

[Manvel]

leaving only cached images (which i still would want gone though).

As soon you launch the browser some images might be cached again, for example icons on launch screen. So I guess you might always see Less then 1mb cache in Clear browsing data page.

Only 1 cookie remains for some reason, the URLs i previously went to were also harder to find, i only could find youtube and github once, which means some extension may be stopping privacy manager from deleting all the data ?

That's might be the case, or the addons does add some data which PM can't clean.

i visited a couple of websites with the addons on, then disabled them then restarted my browser, and all the URLs i previously visited were still there. but i found out that restarting the browser twice does fully clean it.

Would be great to have some reproduction steps with the minimal addons that causes the issue, if possible will be happy to double check.

[Manvel]

@Gomam0n-afk I think, that I have figured out what is the issue with the "Omnibox" remembering some websites from the history even though they are not available there.

Currently Privacy Manager deletes the browsing data on browser start, but I assume Chrome doesn't take that edge case into account when generating in-memory cache, because as it's mentioned in-memory cache is build: During startup, the index must be built as quickly as possible .

Unfortunately I can't find a better solution for this rather than implement Browsing data deletion on Exit rather than on start. I think after fixing #25 Edge case issues caused by race conditions shouldn't be the case anymore.

I'll prioritize the #25 more, but I can't say for sure when exactly this will be fixed, hope that someone would provide patch, otherwise I'll try fixing this early next year(after holidays). Anyway before fixing the issue, I need to figure out an answer to the question:

• Should we keep supporting browsing data deletion on Startup(For backwards compatibility, or any other reasons)?

Thank you for creating this issue and helping with figuring out what causes it thanks to your reproduction steps.

[ghost]

@Gomam0n-afk I think, that I have figured out what is the issue with the "Omnibox" remembering some websites from the history even though they are not available there.

Currently Privacy Manager deletes the browsing data on browser start, but I assume Chrome doesn't take that edge case into account when generating in-memory cache, because as it's mentioned in-memory cache is build: During startup, the index must be built as quickly as possible .

Unfortunately I can't find a better solution for this rather than implement Browsing data deletion on Exit rather than on start. I think after fixing #25 Edge case issues caused by race conditions shouldn't be the case anymore.

I'll prioritize the #25 more, but I can't say for sure when exactly this will be fixed, hope that someone would provide patch, otherwise I'll try fixing this early next year(after holidays). Anyway before fixing the issue, I need to figure out an answer to the question:

* Should we keep supporting browsing data deletion on Startup(For backwards compatibility, or any other reasons)?

Thank you for creating this issue and helping with figuring out what causes it thanks to your reproduction steps.

Thank you for your answer, waiting for a fix, while that's in the works i'll be using firefox.

I think you should delete both on startup and exit as a fail safe.