prismarine-viewer icon indicating copy to clipboard operation
prismarine-viewer copied to clipboard

import all good changes from zardoy fork

Open rom1504 opened this issue 1 year ago • 10 comments

https://github.com/zardoy/prismarine-web-client/commits/main/prismarine-viewer

rom1504 avatar Dec 31 '23 20:12 rom1504

first thing is migrating to esbuild to speed up builds by a lot

rom1504 avatar Dec 31 '23 21:12 rom1504

btw just asking, would it be possible to implement changelogging in github releases like in repo mentioned above? like reading them github releases from mobile

zardoy avatar Dec 31 '23 22:12 zardoy

You mean like https://github.com/PrismarineJS/prismarine-viewer/blob/master/HISTORY.md ?

rom1504 avatar Dec 31 '23 22:12 rom1504

Yes but also include it into release body as text

zardoy avatar Jan 01 '24 08:01 zardoy

could be implemented by changing https://github.com/PrismarineJS/prismarine-template/blob/master/.github/workflows/publish.yml and https://github.com/PrismarineJS/prismarine-repo-actions

but I don't really see a lot of point to it, history.md works well

rom1504 avatar Jan 01 '24 16:01 rom1504

could be implemented by changing PrismarineJS/prismarine-template@master/.github/workflows/publish.yml and PrismarineJS/prismarine-repo-actions

ok thanks, I want to adopt this idea, should be cool: https://github.com/evanw/esbuild/blob/main/.github/workflows/release.yml

zardoy avatar Jan 01 '24 18:01 zardoy

Could be done with a script in the repo to read the README.md / HISTORY.md and pipe to the release action's body. Or just adding a link to the HISTORY.md or README.md's changelog section could work too.

extremeheat avatar Jan 01 '24 19:01 extremeheat

Could be done with a script in the repo to read the README.md / HISTORY.md and pipe to the release action's body

yeah that's more or less what https://github.com/evanw/esbuild/blob/main/.github/workflows/release.yml#L20 do

feel free to try adapting that to our https://github.com/PrismarineJS/prismarine-template/blob/master/.github/workflows/publish.yml @zardoy

rom1504 avatar Jan 01 '24 19:01 rom1504

@zardoy has funded $10.00 to this issue.


IssueHuntBot avatar Jan 21 '24 17:01 IssueHuntBot

@rom1504 @zardoy is it yet open to work?

varshith257 avatar Apr 17 '24 11:04 varshith257