node-minecraft-protocol icon indicating copy to clipboard operation
node-minecraft-protocol copied to clipboard

Add support for new protocol checksum & chatIndex

Open RomainNeup opened this issue 9 months ago • 2 comments

resolve #1385 Waiting for https://github.com/PrismarineJS/minecraft-data/pull/995 to be merge for minecraft-data to be up to date

RomainNeup avatar Mar 26 '25 00:03 RomainNeup

I still have an issue on the client side. I'm investigating, it seems related to the login packet but I checked the protocol (directly by decompiling the client and comparing with 1.21.4) and nothing as changed (at least from my POV).

PartialReadError: Read error for undefined : Missing characters in string, found size is 9 expected size was 12
    at new ExtendableError (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/utils.js:63:13)
    at new PartialReadError (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/utils.js:70:5)
    at Object.string (eval at compile (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:106:15)
    at Object.packet_scoreboard_display_objective (eval at compile (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:3360:57)
    at eval (eval at compile (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:4122:96)
    at packet (eval at compile (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:4162:9)
    at CompiledProtodef.read (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:70:12)
    at e.message (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:111:49)
    at tryCatch (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/utils.js:50:16)
    at CompiledProtodef.parsePacketBuffer (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:111:29)

RomainNeup avatar Mar 26 '25 04:03 RomainNeup

part of 1.21.5 support; tracked at https://github.com/PrismarineJS/mineflayer/issues/3641

rom1504 avatar Apr 27 '25 07:04 rom1504

I still have an issue on the client side. I'm investigating, it seems related to the login packet but I checked the protocol (directly by decompiling the client and comparing with 1.21.4) and nothing as changed (at least from my POV).

PartialReadError: Read error for undefined : Missing characters in string, found size is 9 expected size was 12
    at new ExtendableError (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/utils.js:63:13)
    at new PartialReadError (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/utils.js:70:5)
    at Object.string (eval at compile (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:106:15)
    at Object.packet_scoreboard_display_objective (eval at compile (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:3360:57)
    at eval (eval at compile (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:4122:96)
    at packet (eval at compile (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:4162:9)
    at CompiledProtodef.read (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:70:12)
    at e.message (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:111:49)
    at tryCatch (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/utils.js:50:16)
    at CompiledProtodef.parsePacketBuffer (/Users/romainneuplanche/Documents/perso/github_public/node-minecraft-protocol/node_modules/protodef/src/compiler.js:111:29)

@RomainNeup Is it alright if you could provide a quick overview / steps on how to reproduce this issue? I would be willing to look into it further.

Arc8ne avatar Jun 28 '25 17:06 Arc8ne