node-minecraft-protocol icon indicating copy to clipboard operation
node-minecraft-protocol copied to clipboard

1.19.1-1.19.2

Open PandaUprising opened this issue 3 years ago • 5 comments

Support for 1.19.1-1.19.2

Any updates on this issue? no pressure or anything just wondering where your at with it!

Thank you, PandaUprising

PandaUprising avatar Sep 05 '22 23:09 PandaUprising

Feel free to work on it, I don’t believe anyone is actively working on 1.19.1/2 so far.

extremeheat avatar Sep 06 '22 00:09 extremeheat

It would be interesting if another plugin E.g. ViaVersion could help with this or smth

PandaUprising avatar Sep 06 '22 00:09 PandaUprising

Feel free to work on it, I don’t believe anyone is actively working on 1.19.1/2 so far.

What would I do to add support for these versions?

PandaUprising avatar Sep 06 '22 00:09 PandaUprising

Review the Minecraft Java code diff between 1.19 and 1.19.1 then implement them here

https://github.com/extremeheat/extracted_minecraft_data/pull/1/files

https://github.com/extremeheat/extracted_mcauthlib/pull/1/files

Mainly chat changes

extremeheat avatar Sep 06 '22 00:09 extremeheat

Review the Minecraft Java code diff between 1.19 and 1.19.1 then implement them here

https://github.com/extremeheat/extracted_minecraft_data/pull/1/files

https://github.com/extremeheat/extracted_mcauthlib/pull/1/files

Mainly chat changes

Ok cool, will have a look at that!

Edit: the second link doesn't exist

PandaUprising avatar Sep 06 '22 00:09 PandaUprising

https://github.com/PrismarineJS/minecraft-data/issues/643

rom1504 avatar Oct 12 '22 22:10 rom1504

let's jump straight to 1.19.2 imo

rom1504 avatar Oct 12 '22 22:10 rom1504

https://wiki.vg/index.php?title=Protocol&action=history

rom1504 avatar Oct 12 '22 22:10 rom1504

https://github.com/extremeheat/extracted_minecraft_data/pull/1

rom1504 avatar Oct 16 '22 19:10 rom1504

https://github.com/extremeheat/extracted_minecraft_data/pull/1/files#diff-cfc7f62190ac809b821fb45202a01f8de05f0c3081bd1e6350c6718f53b8692aR809

rom1504 avatar Oct 16 '22 19:10 rom1504

https://github.com/extremeheat/extracted_minecraft_data/pull/1/files#diff-34a0b417dd277e6028b09a69130946df06fe14d800c4f80d6e09a32b030d78aeR12

rom1504 avatar Oct 16 '22 19:10 rom1504

lot of chat stuff changed

rom1504 avatar Oct 16 '22 19:10 rom1504

I'm not super familiar with this project and would like to help, in your opinion what in node-minecraft-protocol most likely needs to change to fit the new minecraft protocol? Just wondering where I should look first.

I'd love to help get 1.19.2 mineflayer going

Shorent avatar Oct 20 '22 22:10 Shorent

only https://github.com/PrismarineJS/minecraft-data/issues/643 copying protocol.json from 1.19 in 1.19.2 folder then making the right changes

rom1504 avatar Oct 20 '22 22:10 rom1504

Support for 1.19.1-1.19.2

Any updates on this issue? no pressure or anything just wondering where your at with it!

Thank you, PandaUprising

YES! please please make it happen!!!!

Fruce avatar Oct 28 '22 07:10 Fruce

Need 1.19.1 and 1.19.2 support asap !

Fruce avatar Oct 28 '22 07:10 Fruce

Need 1.19.1 and 1.19.2 support asap !

You're not in a position to demand anything. This is open-source. Implement it yourself or wait till someone else does the work for you - for free!

s-bauer avatar Nov 07 '22 16:11 s-bauer

Need 1.19.1 and 1.19.2 support asap ! -- @Fruce (https://github.com/PrismarineJS/node-minecraft-protocol/issues/1037#issuecomment-1294575602)

If this is in a production environment then consider hiring a developer to fix it if you are not qualified to do that yourself or submit a bug bounty through e.g. https://issuehunt.io or https://github.com/sponsors/PrismarineJS.

In terms of the amount of bug bountry consider minimal wage per hour and the amount of development hours it will take to solve the issue.

You're not in a position to demand anything. This is open-source -- @s-bauer (https://github.com/PrismarineJS/node-minecraft-protocol/issues/1037#issuecomment-1305858521)

You sound like an annoying child when you make this painfully incompetent excuse, shush and be responsible for the code you write.

Kreyren avatar Nov 08 '22 11:11 Kreyren

How can we implement 1.19(.2)? What changes need to be made?

BasToTheMax avatar Nov 13 '22 09:11 BasToTheMax

See the open PR on the topic. The chat need to be changed.

Feel free to discuss at #contribute in discord

On Sun, Nov 13, 2022, 10:03 Bas @.***> wrote:

How can we implement 1.19(.2)? What changes need to be made?

— Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/node-minecraft-protocol/issues/1037#issuecomment-1312678496, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437SSDQQUBWEL7PWRSBLWICVGBANCNFSM6AAAAAAQFKPV5E . You are receiving this because you commented.Message ID: @.***>

rom1504 avatar Nov 13 '22 10:11 rom1504

https://github.com/PrismarineJS/node-minecraft-protocol/issues/1046 next step is this

rom1504 avatar Nov 28 '22 21:11 rom1504

And now comes 1.19.3...

PandaUprising avatar Dec 08 '22 07:12 PandaUprising

Is 1.19.2 available? And is there any progress on 1.19.3? Just asking.

TinyDerp avatar Dec 16 '22 17:12 TinyDerp

blocked by https://github.com/PrismarineJS/node-minecraft-protocol/issues/1046 ; please read

rom1504 avatar Dec 16 '22 18:12 rom1504

Now that #1046 has been merged, what would be the next steps? Anything that we could help @rom1504?

DanielRamosAcosta avatar Jan 19 '23 23:01 DanielRamosAcosta

hey, What is the progress on 1.19.3? I saw in the latest update 1.19.3 is supported, is this correct?

sebasdt avatar Jan 22 '23 15:01 sebasdt

It's done

Mineflayer PR still open

rom1504 avatar Jan 22 '23 16:01 rom1504