Sign example and implementation fix

[IceTank]

There are some things that did not work with the sign example and the sign implementation. The example was broken and did not work for all versions. It also had references to painting blocks (?) that do not seam to exist anymore. The updateSign function had an issue where it would stringify the sign text in versions 1.9 and above. But sign text is send as a string after 1.8 so empty lines showed up as "" on a sign. updateSign also had an issue where it would brick node-minecraft-protocol by trying to send sign text lines that where undefined.

[IceTank]

Someone could also remake the sign tests. But I don't have a lot of time right now.

[rom1504]

can you please rebase on master ?

[rom1504]

So this removes painting completely from all examples I think we should have an example with paintings, maybe another one than this one

[IceTank]

todo: Make example simpler

[IceTank]

Should I make updateSign and place sign take in an array off strings for the sign text lines? I feel like this would a lot more sense then having to put newline characters into the sign.

[MrAwesome]

For what it's worth, as an end user of the library, an array of strings seems more user-friendly and less brittle.

[IceTank]

This should be done. Waiting for someone to merge or suggest changes.

[rom1504]

can you rebase and push to retrigger ci ?

[extremeheat]

Did you delete the commits ? What happened to the bot.placeSign function?

[rom1504]

closed with label "was good"

Maybe someone will pick it up someday