mineflayer-statemachine icon indicating copy to clipboard operation
mineflayer-statemachine copied to clipboard

Moved dependencies

Open GenerelSchwerz opened this issue 2 years ago • 7 comments

Moved mineflayer dependencies to devDependencies.

GenerelSchwerz avatar Feb 13 '23 15:02 GenerelSchwerz

Addresses #173

GenerelSchwerz avatar Feb 13 '23 15:02 GenerelSchwerz

Note: prismarine-* and vec3 dependencies were also moved since only their types are used; they are never instantiated. Since mineflayer also updates these libraries, statemachine should follow the provided version from mineflayer.

However, these seems slightly worse behavior than simply moving mineflayer and mineflayer-pathfinder, so that's just my personal suggestion.

GenerelSchwerz avatar Feb 13 '23 15:02 GenerelSchwerz

I've also decided to remove minecraft-data as a dependency and switch to prismarine-registry, again as a devDependency. The previously loaded mcData now requires on bot.registry from prismarine-registry.

GenerelSchwerz avatar Feb 13 '23 15:02 GenerelSchwerz

To clarifay, if the user want to use "behaviorMoveTo" need to install manually pathfinder & minecrafr-data & mineflayer? https://github.com/PrismarineJS/mineflayer-statemachine/blob/836c8693d9bf9ba66d5c07046b08debe416a0789/src/behaviors/behaviorMoveTo.ts#L4

I'm not sure if that have sense,

But I understand your vision, since on the other hand this repository is not usually updated much, this would help prevent it from becoming obsolete with new pathfinder updates

sefirosweb avatar Feb 15 '23 16:02 sefirosweb

fails

rom1504 avatar Mar 04 '23 19:03 rom1504

New PR fails, older one works. Fixing now.

To clarifay, if the user want to use "behaviorMoveTo" need to install manually pathfinder & minecrafr-data & mineflayer?

https://github.com/PrismarineJS/mineflayer-statemachine/blob/836c8693d9bf9ba66d5c07046b08debe416a0789/src/behaviors/behaviorMoveTo.ts#L4

I'm not sure if that have sense,

But I understand your vision, since on the other hand this repository is not usually updated much, this would help prevent it from becoming obsolete with new pathfinder updates

Correct, I believe that was the intended behavior before this PR as well.

GenerelSchwerz avatar Mar 05 '23 11:03 GenerelSchwerz

I will open a new PR for my more significant changes. I will revert this branch to just the dependency changes.

GenerelSchwerz avatar Mar 05 '23 11:03 GenerelSchwerz