Incorrect sound ID mapping for all versions

[zardoy]

I just switched to using sound map from mc-data and I see it is mostly ok, but still incorrect for 1.20.4. For example:

Sound with ID 944 must be block.note_block.flute not block.note_block.guitar: https://github.com/PrismarineJS/minecraft-data/blob/8a8c811c71790d75ec405429e5b50343cb77f88b/data/pc/1.20.4/sounds.json#L3774-L3781

@wgaylord

[wgaylord]

Interesting.

[wgaylord]

Havent had time to investigate but unless its an off by 1 error, it shoukd be correct since its generated directly from the registry..

[zardoy]

@wgaylord i actually noticed it a long time ago but never had any free time to post it here:( So it turns out the sound it mapping is wrong for mobs for every version I tried (so it's wrong for all versions here I think), I'm looking for a reliable sound id mapping so I can correctly parse server sound packet. Do you have any suggestions, how can I help or where I can look here? PS Also tried using burger mapping which is by much better but still zombie sound IDs are replaced with some screamers

[zardoy]

Thank god I found actually reliable sound id mapping for every Minecraft version. No wonder ViaVersion does it perfectly (if someone else needs it):

https://github.com/ViaVersion/Mappings//blob/7a45c1f9dbc1f1fdadacfecdb205ba84e55766fc/mappings/mapping-1.21.4.json#L30352

for example zombie step packet id is 1642 and on index 1641 it is correct

[rom1504]

How do they get the data ?

On Wed, Apr 23, 2025, 12:44 Vitaly @.***> wrote:

Thank god I found actually reliable sound id mapping for every Minecraft version. No wonder ViaVersion does it perfectly (if someone else needs it):

https://github.com/ViaVersion/Mappings//blob/7a45c1f9dbc1f1fdadacfecdb205ba84e55766fc/mappings/mapping-1.21.4.json#L30352

for example zombie step packet id is 1642 and on index 1641 it is correct

— Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/minecraft-data/issues/897#issuecomment-2822980134, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437S3C632VANIUK6HG5L224EALAVCNFSM6AAAAAB3URIO4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRSHE4DAMJTGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***> zardoy left a comment (PrismarineJS/minecraft-data#897) https://github.com/PrismarineJS/minecraft-data/issues/897#issuecomment-2822980134

Thank god I found actually reliable sound id mapping for every Minecraft version. No wonder ViaVersion does it perfectly (if someone else needs it):

https://github.com/ViaVersion/Mappings//blob/7a45c1f9dbc1f1fdadacfecdb205ba84e55766fc/mappings/mapping-1.21.4.json#L30352

for example zombie step packet id is 1642 and on index 1641 it is correct

— Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/minecraft-data/issues/897#issuecomment-2822980134, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437S3C632VANIUK6HG5L224EALAVCNFSM6AAAAAB3URIO4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRSHE4DAMJTGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[zardoy]

How do they get the data ?

I think the generator is in the same repo (I saw some java-related code)

[wgaylord]

Our generator works, you just have to make sure your using one for the version we are on. (I don't recall but we just have an off by one error due to the ids getting a number added to them in new versions in the packet.) If I recall 1.20.4 data ended up generated as being off by one since it was pushed before I had fixed the generator. See https://github.com/PrismarineJS/minecraft-data-generator/commit/44f49b4ab51fb92f72209d7fdf7c6e42030de8dd I don't recall why the sound mapping generator has not been updated for new versions after 1.20 tho.

[rom1504]

Would be great to fix. Maybe we can also add a test in minecraft-data tests to cross check against via version

On Wed, Apr 23, 2025, 13:10 William Gaylord @.***> wrote:

Our generator works, you just have to make sure your using one for the version we are on. (I don't recall but we just have an off by one error due to the ids getting a number added to them in new versions in the packet.) If I recall 1.2 data ended up generated as being off by one since it was pushed before I had fixed the generator. See @.*** https://github.com/PrismarineJS/minecraft-data-generator/commit/44f49b4ab51fb92f72209d7fdf7c6e42030de8dd I don't recall why the sound mapping generator has not been updated for new versions after 1.20 tho.

— Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/minecraft-data/issues/897#issuecomment-2823005661, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437XC2CM76SS37EBNG2D224HEDAVCNFSM6AAAAAB3URIO4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRTGAYDKNRWGE . You are receiving this because you commented.Message ID: @.***> wgaylord left a comment (PrismarineJS/minecraft-data#897) https://github.com/PrismarineJS/minecraft-data/issues/897#issuecomment-2823005661

Our generator works, you just have to make sure your using one for the version we are on. (I don't recall but we just have an off by one error due to the ids getting a number added to them in new versions in the packet.) If I recall 1.2 data ended up generated as being off by one since it was pushed before I had fixed the generator. See @.*** https://github.com/PrismarineJS/minecraft-data-generator/commit/44f49b4ab51fb92f72209d7fdf7c6e42030de8dd I don't recall why the sound mapping generator has not been updated for new versions after 1.20 tho.

— Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/minecraft-data/issues/897#issuecomment-2823005661, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437XC2CM76SS37EBNG2D224HEDAVCNFSM6AAAAAB3URIO4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRTGAYDKNRWGE . You are receiving this because you commented.Message ID: @.***>

[zardoy]

If I recall 1.20.4 data ended up generated as being off by one since it was pushed before I had fixed the generator

Not only 1.20.4, 1.19.2 for example, also needs +1 for correct mapping for use with sound effect packet

Also, I was testing on versions like 1.19.4 and it turns out we simply don't have sound id mapping here for these versions, that's why I thought it was completely wrong for such versions. I think it's better to modify the mc data code to not add sound data for missing versions (but tbh I still need data for every version). I think it makes sense to generate such data for every version since IDs are different. The current approach is very confusing

btw also noticed that the type definition for sounds is missing