minecraft-data
minecraft-data copied to clipboard
PrismarineJS
Add Advancements Data
I've created an advancement data file for another project and noticed that this repo doesnt have data for advancements yet.
Eejit and I adjusted it to fit the style of other data files and we added lots of new informational properties.
- [x] Advancements
- [x] Advancement criteria
- [x] Older Versions
- [x] Added schema
- [x] Updated READMEs
How did you create it?
At first, I just copied over each of the properties manually, but i realised I could've just used the advancements table of the fandom wiki and convert it to json using a tool. For the criteria, Ill have to do them manually as they are not listed anywhere on the wiki.
Is there anything wrong with it? Because the CI test did fail 🤔
Only that it isn't included in dataPaths.json
How did you create it?
At first, I just copied over each of the properties manually, but i realised I could've just used the advancements table of the fandom wiki and convert it to json using a tool. For the criteria, Ill have to do them manually as they are not listed anywhere on the wiki.
This could probably all be automated using the minecraft language file.
How did you create it?
At first, I just copied over each of the properties manually, but i realised I could've just used the advancements table of the fandom wiki and convert it to json using a tool. For the criteria, Ill have to do them manually as they are not listed anywhere on the wiki.
This could probably all be automated using the minecraft language file as it contains all the advancement descriptions, displaynames and IDs (resource locations).
I'll work on making a tool to generate this automatically
If you want, I can do it myself :D
Unsure about the CI test, but already working on that tool. I'll let you know when I make progress!
Unsure about the CI test, but already working on that tool. I'll let you know when I make progress!
Okay, sure then!
Alright I've made a a tool to generate it. I'll create a separate PR and add that data there!
G
Alright I've made a a tool to generate it. I'll create a separate PR and add that data there!
Awesome!
Why is this data helpful? Wouldn’t it be more helpful for you to just access the raw advancement json from a datapack?
Why is this data helpful? Wouldn’t it be more helpful for you to just access the raw advancement json from a datapack?
It's great to have every minecraft data combined in a single package. I'm not exactly sure about the raw advancement json youre talking about. Isnt every advancement stored in seperate files which makes everything very inconvenient? Also, the displayName and description are in the language file only and not included in the raw json.
@Eejit43 Let me know if you want me to change the format to anything specific.
Data for other versions, back to 1.12 should also be added
u9g said separate PRs should be created, is that not the case?
Separate PRs for different features, one PR per feature. Doing separate PRs per version here would mean 10 different PRs with possibly incompatible schemas, so I believe it makes sense to also test that your current schema works on all present versions
Separate PRs for different features, one PR per feature. Doing separate PRs per version here would mean 10 different PRs with possibly incompatible schemas, so I believe it makes sense to also test that your current schema works on all present versions
alright I'll start on that but we'll need to wait a day until Lianecx will accept my PR
Your PR has already been merged to this Lianecx's branch
I'm aware of that, you said you wanted me to add the data for the other versions to this PR, which I'll have to make a PR to their repository first
Yes you can collaborate with them on it (PRs are how github collaboration works, but Lianecx can also give you write perms to the branch if he wants)
Yes you can collaborate with them on it (PRs are how github collaboration works, but Lianecx can also give you write perms to the branch if he wants)
They didn't give me perms however so we'll have to wait.
No rush to merge this PR, just focus on the work :). Will be reviewed by rom/u9g when it's ready for review
Yes you can collaborate with them on it (PRs are how github collaboration works, but Lianecx can also give you write perms to the branch if he wants)
They didn't give me perms however so we'll have to wait.
Just open a pr, no need to wait.
Separate PRs for different features, one PR per feature. Doing separate PRs per version here would mean 10 different PRs with possibly incompatible schemas, so I believe it makes sense to also test that your current schema works on all present versions
alright I'll start on that but we'll need to wait a day until Lianecx will accept my PR
I dont understand why youre in such a rush. You didnt even create a PR otherwise it wouldve been merged by now.