minecraft-data icon indicating copy to clipboard operation
minecraft-data copied to clipboard

entity_effect : rename hideParticles to flags

Open Robbilie opened this issue 2 years ago • 0 comments

In reference to: https://github.com/PrismarineJS/node-minecraft-protocol/issues/951

Would it be possible to rename the hideParticles field to flags like in the protocol definitions? https://wiki.vg/Protocol#Entity_Effect

hideParticles is a bit missleading and doesnt represent the two other values behind the flags

        "packet_entity_effect": [
          "container",
          [
            {
              "name": "entityId",
              "type": "varint"
            },
            {
              "name": "effectId",
              "type": "i8"
            },
            {
              "name": "amplifier",
              "type": "i8"
            },
            {
              "name": "duration",
              "type": "varint"
            },
            {
              "name": "hideParticles",
              "type": "i8"
            }
          ]
        ]

Robbilie avatar Jan 09 '22 19:01 Robbilie