minecraft-data icon indicating copy to clipboard operation
minecraft-data copied to clipboard

Recursive 'itemstacks' definition

Open barneygale opened this issue 4 years ago • 6 comments

The definition of PE's 'itemstacks' type itself refers to 'itemstacks': https://github.com/PrismarineJS/minecraft-data/blob/4e9c6056ccb42379f6ff4c017504f26441edf992/data/pe/0.15/protocol.json#L316-L330

barneygale avatar Jan 30 '21 20:01 barneygale

Yeah that seems broken indeed. I believe @extremeheat is working on an updated version for a newer version

rom1504 avatar Jan 30 '21 20:01 rom1504

Nice. I'm going to try to put together a definition for RakNet too, which shouldn't ever need to change. Don't expect it any time soon, though :)

barneygale avatar Jan 30 '21 21:01 barneygale

We have one at https://github.com/mhsjlw/node-raknet/blob/master/data/protocol.json It works, just missing implementing ack queues on the js side

rom1504 avatar Jan 30 '21 21:01 rom1504

Yes, I'm working on updating it with the protocol library to 1.16. What's your use case? I should have something working soon.

extremeheat avatar Jan 31 '21 03:01 extremeheat

Here's an updated ProtoDef protocol definition for bedrock 1.16 if you needed, https://github.com/extremeheat/pocket-minecraft-protocol/blob/new/data/newproto.json

I have it generated from two yaml files for now, https://github.com/extremeheat/pocket-minecraft-protocol/tree/new/data/new through this tool https://github.com/extremeheat/protodef-yaml. This makes maintenance easier and adds comment support.

Expect lots of errors and changes, most of this is manual and has yet to be tested. Once it's stable we can move the definitions to mc-data.

extremeheat avatar Feb 07 '21 11:02 extremeheat

Amazing! I'll give it a spin soon.

barneygale avatar Feb 07 '21 17:02 barneygale