Prism icon indicating copy to clipboard operation
Prism copied to clipboard

Add Missing XML Docs

Open dansiegel opened this issue 6 years ago • 12 comments

Summary

Many API's are currently lacking XML docs or have invalid markup. As we begin to explore adding API documentation to the Prism Docs, we need to update the existing codebase with more complete XML docs so that these docs can be generated for the docs site.

HACKTOBERFEST UPDATE

Thank you for joining us for your Hacktoberfest contributions... Please take some time to familiarize yourself with this issue. If you submit PR's for a single method in a single class please expect your PR to be closed as invalid

NOTE

While updated and added XML docs should include Summaries, and information for parameters/return values, it will often be better to ensure that remarks and examples are included as this will make the generated API docs more useful. Additional information on proper doc tags can be found here.

/// <summary>
/// The GetZero method.
/// </summary>
/// <example> 
/// This sample shows how to call the <see cref="GetZero"/> method.
/// <code>
/// class TestClass 
/// {
///     static int Main() 
///     {
///         return GetZero();
///     }
/// }
/// </code>
/// </example>
public static int GetZero()
{
    return 0;
}

dansiegel avatar Dec 21 '19 05:12 dansiegel

Hey.

I'm happy to chip in with this. Is there any particular area that you'd like to be covered first?

ghost avatar Feb 06 '20 15:02 ghost

@rssllgrrtt if you build in Release you'll see a whole bunch of warnings with the following codes

CS1570 CS1572 CS1573 CS1574 CS1591

Just double click the warning and you should be taken to where the warning is and you can either fix bad blocks or add missing docs depending on what the code was for. You don't need to do everything and please don't try to do it all in a single PR.

dansiegel avatar Feb 06 '20 16:02 dansiegel

@dansiegel OK, not a problem. I'll take a look at that in the next few days.

I won't be submitting loads of PR(s) anyway. I've been using Prism for years, but I'm new(ish) to GitHub and contributing. I'd be scared of submitting a big PR until I'm comfortable. I just figure it's time I started to give back :)

Thanks.

ghost avatar Feb 06 '20 17:02 ghost

Public Service Announcement... Before submitting a PR... or working on one... Be sure to leave a comment here for which classes/types you will be making changes for. This will help others from working on XML Docs for the same types/methods.

dansiegel avatar Apr 22 '20 14:04 dansiegel

If nobody is already working on it, I would tackle the following files from Prism.Core next:

  • ModuleState.cs
  • IModuleCatalogItem.cs
  • TaskExtensions.cs
  • IModuleInfoGroup.cs
  • ModuleNotFoundException.cs

WaldemarCoding avatar Apr 24 '20 19:04 WaldemarCoding

Submitted PR for documentation updates to the following files: ApplicationStore.cs EventToCommandBehavior.cs IApplicationLifecycleAware.cs IApplicationStore.cs RuntimePlatform.cs

I skipped: IAutoInitialize.cs as @dansiegel said he is working to remove it

d3fkn1ght avatar Apr 28 '20 03:04 d3fkn1ght

I'm currently working on:

  • IApplicationProvider
  • ApplicationProvider
  • IParameters
  • IDialogParameters
  • IDialogService
  • DialogService
  • IDialogServiceExtensions

cabauman avatar Oct 18 '20 04:10 cabauman

Figured I'd help out and write some documentation for navigation in Prism.Forms. Learned a little bit while doing it too.

Adam-- avatar Jun 08 '21 16:06 Adam--

I never contribute OSS, but I try this issue. I will work below item as first step.

  • IModuleGroupsCatalog

niimima avatar Jul 22 '21 10:07 niimima

@niimima every little bit helps

brianlagunas avatar Jul 22 '21 16:07 brianlagunas

I will work below items.

  • IDialogResult
  • DialogResult

niimima avatar Aug 22 '22 11:08 niimima