PrismLauncher icon indicating copy to clipboard operation
PrismLauncher copied to clipboard

witch hat costume for halloween party cat 🎃

Open leozamboni opened this issue 2 years ago • 13 comments

a witch hat for halloween but one day later :(

leozamboni avatar Nov 01 '22 23:11 leozamboni

You'd probably coordinate with the folks at #372 and also add a spooky Rory <:)

flowln avatar Nov 01 '22 23:11 flowln

Should I make a Spooky Rory?

AshtakaOOf avatar Nov 02 '22 00:11 AshtakaOOf

please, themed stuff are cool

leozamboni avatar Nov 02 '22 00:11 leozamboni

Please integrate this with the system introduced by #372

Scrumplex avatar Nov 02 '22 11:11 Scrumplex

Basically you just need to add a -ween suffix (or anything else) to the cat string in the logic and save the variants with that suffix too. So most of the logic can be reused!

santiagocezar avatar Nov 02 '22 12:11 santiagocezar

Why’s this closed?

RaptaG avatar Nov 02 '22 13:11 RaptaG

I'm fixing

leozamboni avatar Nov 02 '22 13:11 leozamboni

In that case making this a draft is nicer I think

Scrumplex avatar Nov 02 '22 14:11 Scrumplex

Oh. I thought I can make it a draft myself

Scrumplex avatar Nov 02 '22 14:11 Scrumplex

github automatically closed the pr to update my fork, I don't know why

leozamboni avatar Nov 02 '22 14:11 leozamboni

It seems the if statement's formatting is a little inconsistent. Yes... That's right... Time for clang-format.

TheKodeToad avatar Nov 02 '22 16:11 TheKodeToad

  • 6b856c9 formatted the entire file by mistake
  • 498a1cd revert and format only the block

leozamboni avatar Nov 02 '22 18:11 leozamboni

BTW you can probably just squash the changes once you're done, so don't worry about those commits

santiagocezar avatar Nov 02 '22 18:11 santiagocezar

@leozamboni Can you squash all your commits into one? We could do that when merging on GitHub, but that would replace your own signature with GitHub's signature. If you need help, do not hesitate to ask.

Scrumplex avatar Nov 04 '22 17:11 Scrumplex