PrismLauncher icon indicating copy to clipboard operation
PrismLauncher copied to clipboard

Downloading packs with invalid characters freezes

Open rogama25 opened this issue 1 year ago • 0 comments

Operating System

Windows

Version of Prism Launcher

Prism Launcher 8.3

Version of Qt

Qt 6.6.3

Description of bug

Trying to download a pack whose download contains an illegal character fails without notifying the user

Steps to reproduce

  • Create a new instance
  • Select Whimsical Wonders modpack in Modrinth
  • Choose one of the 4.X versions (tested with 4.1.4)
  • Progress freezes, and outputs [launcher.task.net]: "Could not open C:/Users/rodri/AppData/Roaming/PrismLauncher/cache/cdn.modrinth.com/data/PmwWNPV6/versions/gfSMbKRc/Technical Electrical: Whimsical Wonders-4.1.4.mrpack for writing" to the terminal

Suspected cause

The author upload this pack with the : (colon) symbol on the pack file, which is not an allowed character on Windows

This issue is unique

  • [X] I have searched the issue tracker and did not find an issue describing my bug.

rogama25 avatar Apr 30 '24 18:04 rogama25