PrismLauncher icon indicating copy to clipboard operation
PrismLauncher copied to clipboard

Old neoforge installer versions are broken

Open Fiibii853 opened this issue 1 year ago • 6 comments

Operating System

Windows, Linux

Version of Prism Launcher

Prism Launcher 8.2

Version of Qt

Qt 6.6.2

Description of bug

Trying to install old versions of neoforge is broken. I tested with neoforge 47.1.28 but I think it's possible that all versions below .185 are effected. Testing with the modrinth app worked with no problems.

I am using Minecraft 1.20.1

Steps to reproduce

Create a new 1.20.1 instance with neoforge 47.1.28 Attempt to run See that console has an error: Caused by: java.lang.RuntimeException: java.lang.SecurityException: no manifest section for signature file entry com/google/gson/internal/bind/JsonTreeWriter.class at io.github.zekerzhayard.forgewrapper.installer.Installer.createInstaller(Installer.java:40)

Suspected cause

I believe this is a problem with the forgewrapper used, probably due to https://github.com/neoforged/NeoForge/issues/671. I would guess that whatever was done to fix the broken installers has not been taken into account in the wrapper.

Might be related to this https://github.com/PrismLauncher/PrismLauncher/issues/2128?

This issue is unique

  • [X] I have searched the issue tracker and did not find an issue describing my bug.

Fiibii853 avatar Mar 22 '24 23:03 Fiibii853

Duplicate of: https://github.com/PrismLauncher/PrismLauncher/issues/2170

Remove the meta folder that is inside prism root folder and try again.

Trial97 avatar Mar 23 '24 06:03 Trial97

The error still occurs after deleting the meta folder.

I should also note that this was a fresh prism install, so I don't think that the solution mentioned in https://github.com/PrismLauncher/PrismLauncher/issues/2170 has fixed the neoforge installer.

Fiibii853 avatar Mar 23 '24 10:03 Fiibii853

Looks like is not the meta issue it is something else: reopening it

Trial97 avatar Mar 23 '24 10:03 Trial97

Just for tracking: the first version that works is 47.1.83

Trial97 avatar Mar 23 '24 10:03 Trial97

This also happens when running the jar directly: download link

TheKodeToad avatar Mar 23 '24 11:03 TheKodeToad

Opened an issue on neoforge to clarify things:https://github.com/neoforged/NeoForge/issues/740

Trial97 avatar Mar 23 '24 22:03 Trial97

This works now

Trial97 avatar May 02 '24 20:05 Trial97