Alexander Prinzhorn

I think I can pretty much answer my question from above. Here's the current implementation https://github.com/mitmproxy/mitmproxy/blob/57e65d3d1f28031ca087fca47cd13341ee76f210/mitmproxy/contentviews/json.py As you can see it uses ` json.loads` and `json.JSONEncoder`. To achieve what you...

I don't even know were to begin writing tests. What you're saying is I shouldn't use `from multiprocessing import Process` to spawn a process and test the exit code, but...

I wouldn't say I know what I'm doing, but I added a test. Now if we find a more meaningful numbering system we're good to go? I tried to keep...

@mhils can you check this out? The 100% CPU keeps making trouble, now with the e2e tests that don't exit cleanly.

> if you touch test/mitmproxy/utils/test_exit_codes.py and fix the merge conflicts 5133 is good to go

> please tell me how to do it. `mitmdump --mode socks5 --set proxy_debug -vvv`

I was able to reproduce this once but not consistently. I had two browsers open at `8081`, then opening a browser that proxied a website with lot of requests and...

After doing some digging this might as well be caused by an upstream bug https://github.com/tornadoweb/tornado/issues/2958 which would cause the WebSocket to never be removed from the set: https://github.com/mitmproxy/mitmproxy/blob/73c38f698d42002947e46294498b2166f3139cf4/mitmproxy/tools/web/app.py#L275-L283

> Honestly it feels like we should just swallow the error in `broadcast` [here](https://github.com/mitmproxy/mitmproxy/blob/73c38f698d42002947e46294498b2166f3139cf4/mitmproxy/tools/web/app.py#L292-L295) and be done with it. And also `if closedError: self.connections.remove(self)` :eyes: ? But I think that...

> Perhaps the widget translation key could be shown discretely somewhere on the widget UI via a hover over, or an API call added to provide a list. What I've...