openpiton icon indicating copy to clipboard operation
openpiton copied to clipboard

fix: prevent latch inference

Open tianrui-wei opened this issue 2 years ago • 2 comments

This PR prevents latch inference by assigning a default value to msg_send_data_size_S4

tianrui-wei avatar Oct 09 '23 17:10 tianrui-wei

cc @Jbalkind @fei-g The latch inference seems to come from https://github.com/PrincetonUniversity/openpiton/commit/a39066a186fae18122949cfec4027f11eb09c3e4. Would you have any insight on why the comments was inserted?

tianrui-wei avatar Oct 09 '23 17:10 tianrui-wei

I don't remember exactly why did I comment that out.. Just checked the L15 decoder, and I found that it didn't look into the data_size field. I think in L15 pipeline it will use the data size stored in MSHR. So, we are okay to set the default data_size to 0. But If you have other modules that need the data_size info, the best way might be just uncomment those lines back (or set default data size to data_size_S4_f).

fei-g avatar Oct 09 '23 18:10 fei-g