PsyNeuLink icon indicating copy to clipboard operation
PsyNeuLink copied to clipboard

requirements: Update numpy to <1.22.5

Open jvesely opened this issue 3 years ago • 4 comments

Do not check for string values of numpy errors. Refactor exception handling to check only calls to 'execute'.

jvesely avatar Aug 31 '22 16:08 jvesely

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

Only in docs-base/_images: Composition_XOR_animation.gif

...

See CI logs for the full diff.

github-actions[bot] avatar Aug 31 '22 16:08 github-actions[bot]

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

github-actions[bot] avatar Aug 31 '22 18:08 github-actions[bot]

Coverage Status

Coverage: 84.154% (-0.0003%) from 84.154% when pulling e114a8fc4f6d0b7a8beab9f1463efa9e4643ffae on dependabot/pip/devel/numpy-gte-1.17.0-and-lt-1.22.5 into 44a2f2ee734342a58a0ecc53a79a78ab7ef3cdf7 on devel.

coveralls avatar Aug 31 '22 19:08 coveralls

lgtm, doesn't seem critical to have the exact numpy error text not change

thank you. It looks like 1.22 is also hitting some numerical issues which I thought were introduced in 1.23 (this PR passes locally on my Linux setup). I'll keep this open and rebase after investigating those.

jvesely avatar Sep 02 '22 22:09 jvesely

lgtm, doesn't seem critical to have the exact numpy error text not change

thank you. It looks like 1.22 is also hitting some numerical issues which I thought were introduced in 1.23 (this PR passes locally on my Linux setup). I'll keep this open and rebase after investigating those.

the issues are now tracked in #2572

jvesely avatar Jan 10 '23 02:01 jvesely

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

github-actions[bot] avatar Jan 10 '23 20:01 github-actions[bot]

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

github-actions[bot] avatar Jan 13 '23 03:01 github-actions[bot]

Ignoring results of the x86 CI job. It can't uninstall numpy because it was installed in the restricted package set one step earlier.

jvesely avatar Jan 13 '23 04:01 jvesely