StockAlertBot icon indicating copy to clipboard operation
StockAlertBot copied to clipboard

Fix Verizon Straight Talk Conflict add MMS

Open curiouscrusher opened this issue 2 years ago • 4 comments

Changes

  • I noticed when saving my SMS via Email notification settings that any recurring visits to the settings page showed "Straight Talk" instead of "Verizon" in the drop down. Turns out they each have the same SMS Email address, so I consolidated both Verizon & Straight Talk into single dropdown option.
  • Verizon SMS Email sends a traditional SMS which has a character limit. Between the subject line, console/store/date/credit info I wasn't even getting half the url to the store page in my text. After some quick testing I found Verizon supports MMS messaging via [email protected]. I tested and confirmed this sent successfully and included all the information, most importantly the entire product url. It appears there are also MMS addresses for AT&T and other major carriers, unfortunately I can only test Verizon currently.
  • My IDE cleaned up a bunch of extra whitespaces in the index.html

curiouscrusher avatar Nov 18 '21 19:11 curiouscrusher

Hi @Prince25, thanks for reviewing! I can go through and dig up some other carrier MMS addresses and add them in here for sure, will try and do that this weekend.

Cheers

curiouscrusher avatar Nov 19 '21 16:11 curiouscrusher

As promised @Prince25, pushed those changes! I consolidated all carriers that share an address, added all the additional MMS addresses I could find, and updated the tooltip with some notes about the SMS vs MMS sending.

curiouscrusher avatar Nov 22 '21 17:11 curiouscrusher

Thank you!! It looks good to me. Have you seen what the longer Carrier names look like on the settings page?

One final thing would be to update the Email part of the SMS section of the README. Could you just update the carriers and perhaps briefly explain the difference between SMS and MMS? Appreciate it. https://github.com/curiouscrusher/StockAlertBot/blob/b59b7678b6c2e8b7f86a2a2a9ddbfe7b1aecdc26/README.md?plain=1#L173

Prince25 avatar Nov 23 '21 05:11 Prince25

Hey @Prince25, sorry for the delay! Holiday madness set in and I've been slammed.

I'm guessing the longer carrier names don't look so great in the Material dropdowns? I'll have some downtime for the holidays starting next week, I can take a look at the visual for the dropdowns and write up some explanation on MMS/SMS too.

Cheers!

curiouscrusher avatar Dec 16 '21 15:12 curiouscrusher