Inkay icon indicating copy to clipboard operation
Inkay copied to clipboard

Fix aroma beta 17 incompatibilities, fix debug logger, bump version

Open TraceEntertains opened this issue 9 months ago • 9 comments

Pretty self explanatory Works fine on my wii u but will mark as a draft until confirmed working

TraceEntertains avatar May 07 '24 08:05 TraceEntertains

Code looks good to me, though you've got mixed tabs/spaces. Might want to see if whatever editor your using has an EditorConfig plugin.

ashquarky avatar May 08 '24 02:05 ashquarky

did a bunch of stuff but notifications still arent the way i wanted them to be, still a draft for now but i pushed all my latest changes so if anyone wants to take a look they can

TraceEntertains avatar May 08 '24 06:05 TraceEntertains

Code looks good to me, though you've got mixed tabs/spaces. Might want to see if whatever editor your using has an EditorConfig plugin.

i do actually have multiple ides installed but i just use notepad++ because it starts quickly and is just files rather than folder/project based (i'll just end up using vscode anyways probably so its fineeeeee)

TraceEntertains avatar May 08 '24 06:05 TraceEntertains

oh crap, the commit i put has debug defaulted to on (you can just comment out the "DEBUG := 1" makefile line if you dont want debug but it will be commented before the pr is marked as ready for review) (i figured in general it would be good to have it in there in some form for beginners and such)

TraceEntertains avatar May 08 '24 06:05 TraceEntertains

I made a PR for that PR: https://github.com/TraceEntertains/Inkay/pull/1

Maschell avatar May 08 '24 11:05 Maschell

Inkay-pretendo.zip Here's the plugin in a zip file (thanks github...) if anyone wants to test it

TraceEntertains avatar May 08 '24 19:05 TraceEntertains

Testing it and everything is working as expected, the message now shows up after boot and patching the wara wara plaza works now

FourHawk avatar May 08 '24 22:05 FourHawk

Using Aroma v19 with your release TraceEntertains and after a few reboots Mario Kart worked but for example with Splatoon (Lobby) I still get Error 101-0502/101-2210/ and others. It seems not to be 100% compatible to me for the moment.

Ch3ck3rM0n avatar May 09 '24 07:05 Ch3ck3rM0n

Error code 101-0502 Normally just means that the server is overloaded, idk about 101-2210 however

FourHawk avatar May 09 '24 10:05 FourHawk

It seems to be working for me on Aroma Beta 18, yesterday night I was able to play a Splatoon match.

ItzSwirlz avatar May 10 '24 15:05 ItzSwirlz

@jonbarrow PR generally seems to be working on Aroma Beta 17+, and its been sitting for a few days now, is it possible you could review this when you get the chance?

TraceEntertains avatar May 11 '24 04:05 TraceEntertains

Alright we'll call it good

ashquarky avatar May 13 '24 05:05 ashquarky