ps_checkout icon indicating copy to clipboard operation
ps_checkout copied to clipboard

Published 20 hours ago • verified publisher icon PrestaShopCorp

Upgrade PHPStan to latest version (PrestaShop 8)

Open Quetzacoalt91 opened this issue 1 year ago • 1 comments

Since the first implementation of PHPStan in our development process, we did not increase the version because the docker image had changed. We were stuck on PHPStan - PHP Static Analysis Tool 0.12.89, a version released on 09/06/2021.

Keeping our tools up-to-date is important for the stability of our projects. However newer versions were using PHP 8 in their Docker image, preventing it to work with old version of PrestaShop. This PR add PHPStan as a composer dependency so we can control the version used with the lock file, and we updated the CI workflow so PrestaShop versions are manually downloaded and unzipped.

  • [ ] Some errors will appear with the rules added. There are to way to fix this: Fix all the errors in the same PR, or add a baseline. I would prefer the first solution as it may fix some issues.

Replaces #1009

Quetzacoalt91 avatar Mar 21 '23 13:03 Quetzacoalt91

@Matt75 I need your opinion on this PR and #1011. How confident are you in fixing errors in this PR? Otherwise we can ignore them until the code is modified for the first time.

Quetzacoalt91 avatar Mar 21 '23 16:03 Quetzacoalt91