prestashop-ui-kit
prestashop-ui-kit copied to clipboard
PrestaShop
Fix deprecation notices on divisions without calc()
| Questions | Answers |
|---|---|
| Description? | While building a project with a recent version of SASS, I get deprecation notices that are coming from this library (Details on the error at the bottom). |
| Type? | refactor |
| BC breaks? | Nope |
| Deprecations? | Nope |
| Fixed ticket? | / |
| Sponsor company | / |
| How to test? | The result on the style must be the same as before. If something goes wrong, it would be likely the spacing between elements or ps tagger. |
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($pixels, $context) or calc($pixels / $context)
More info and automated migrator: https://sass-lang.com/d/slash-div
@tleon @mflasquin Dont forget to add the "Waiting for QA" label else the PR will never move forward
Hello @Quetzacoalt91
Thank you for your PR, I try it on 8.0.5 and here's what I got :
there is not enought space between some component as you can see :
Before :
After :
Before :
After :
About the dropdown button with a big down arrow on it, they are not centered in the same way and they don't have the same highlight :
Before :
After :
Before :
After :
Images doesn"t have the same space as before as you can see :
Before :
After :
Before :
After :
The checkboxes are not properly checked as you can see :
The font looks a little different on the Order page, as you can see :
Before :
After :
I hope that all these screens can help you in the improvement of your PR
Waiting for your feedback
Thank you
Thanks for the feedback. I'll have a look at it later, as I struggled a bit to load my local instance today. :)