hummingbird icon indicating copy to clipboard operation
hummingbird copied to clipboard

v1.0.0 release does not contain zip packaged version of the theme

Open prestaalba opened this issue 11 months ago • 3 comments

The zip asset was not uploaded to the release page:

https://github.com/PrestaShop/hummingbird/releases/tag/v1.0.0

Release workflow requires some checking so that new releases get the zip package for easier downloading.

prestaalba avatar Jan 30 '25 14:01 prestaalba

Maybe this? https://github.com/PrestaShop/hummingbird/actions/runs/13035311945/job/36730414086

tswfi avatar Mar 12 '25 07:03 tswfi

@tswfi sorry but where can I find the release zip on that github action??

prestaalba avatar Mar 12 '25 15:03 prestaalba

I mean that the problem is somewhere there. Didn't have time to check closer what the problem was though...

tswfi avatar Mar 12 '25 16:03 tswfi

Can someone tell me the best way to perform the update? https://github.com/PrestaShop/hummingbird/releases/tag/v1.0.0

Why isn't version 1.0.0 already included in PrestaShop 9?

Regards Roger

Rogwalk avatar Jun 14 '25 23:06 Rogwalk

Hello, it seems there is 2 questions here:

  1. Why v1.0.0 release does not contain zip packaged version of the theme?

A GitHub release is simply a GitHub object that references a git tag, which is https://github.com/PrestaShop/hummingbird/commit/fbb97bcfb0184b1620a959cf32fb9f0e428ae474 here . It does not have to contain a packaged zip, this is a development artifact.

We include Hummingbird inside PrestaShop using Packagist, see https://github.com/PrestaShop/PrestaShop/blob/develop/composer.json#L72

I understand having a ready-to-download packaged zip would be useful but as we don't need it, we did not built it. You can either build the zip yourself following the README instructions or ~you could also submit a Pull Request to add a GitHub workflow that build it for next release~ 😉

EDIT: My bad: there was already a GitHub action to build it, however it failed :/ as mentioned by @tswfi

  1. Why isn't version 1.0.0 already included in PrestaShop 9?

The 1.0.0 release has been included in PrestaShop 9 but unfortunately we got a version number issue: the config.yml file of release 1.0.0 contains the wrong version number. This is will be fixed in upcoming patch version 1.0.1 but I assure you PrestaShop 9 contains the code content of the 1.0.0 release

matks avatar Jun 15 '25 15:06 matks