example-modules icon indicating copy to clipboard operation
example-modules copied to clipboard

Introduce module demoextendtemplates

Open zuk3975 opened this issue 2 years ago • 2 comments

Questions Answers
Description? Introduce demo module showing how to extend and modify core pages twig templates (see more detailed info in readme)
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? install the module, go to orders page and refer to screenshot bellow to make sure module shows all modifications in orders page.Screenshot from 2022-09-15 13-57-15

| Possible impacts? | Please indicate what parts of the software we need to check to make sure everything is alright.

zuk3975 avatar Sep 15 '22 11:09 zuk3975

Raised related PR to fix orders stylesheets parent call. https://github.com/PrestaShop/PrestaShop/pull/29646

zuk3975 avatar Sep 15 '22 11:09 zuk3975

also blocked by https://github.com/PrestaShop/PrestaShop/pull/29322 (because the example includes decorating order controller and it breaks whole page until the bug is fixed)

zuk3975 avatar Sep 15 '22 11:09 zuk3975

Raised related PR to fix orders stylesheets parent call. PrestaShop/PrestaShop#29646

Hello @zuk3975 is this the last blocking PR?

matks avatar Nov 18 '22 17:11 matks

Raised related PR to fix orders stylesheets parent call. PrestaShop/PrestaShop#29646

Hello @zuk3975 is this the last blocking PR?

yes, as I mentioned in that issue, both PRs should probably be approved by single QA check.

zuk3975 avatar Nov 21 '22 09:11 zuk3975

Tested in combination with https://github.com/PrestaShop/PrestaShop/pull/29646

It is QA ✅ See https://github.com/PrestaShop/PrestaShop/pull/29646#pullrequestreview-1190458860

florine2623 avatar Nov 22 '22 16:11 florine2623

@PrestaShop/committers, @PrestaShop/prestashop-maintainers as Florine tested another related PR it was a nice occasion to approve this PR even though it doesn't yet have mainatiners approvals. So could you please approve it (and merge once the related pr is merged)? :smile:

zuk3975 avatar Nov 22 '22 17:11 zuk3975