classic-theme icon indicating copy to clipboard operation
classic-theme copied to clipboard

Fix order return checkbox selector

Open SharakPL opened this issue 3 months ago • 0 comments

Questions Answers
Description? https://github.com/PrestaShop/classic-theme/commit/a9c26cec9d1733dd4ed99fbd6cabf7fe963f2afe added .js- selectors in few places.
The one for order returns got messed up. It's supposed to be:
#order-return-form table thead input[type=checkbox], .js-order-return-form table thead input[type=checkbox]
#order-return-form table tbody input[type=checkbox], .js-order-return-form table tbody input[type=checkbox]
but instead it became:
#order-return-form, .js-order-return-form table thead input[type=checkbox]
#order-return-form, .js-order-return-form table tbody input[type=checkbox].
This pr simplifies the selectors and the function to check all products for return.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? 1. Have an order with several products in your customer account
2. Start a return process and see if you can check all products at once from the table header

SharakPL avatar Mar 20 '24 20:03 SharakPL