autoupgrade icon indicating copy to clipboard operation
autoupgrade copied to clipboard

Change feature value table to add position field

Open ks129 opened this issue 1 year ago • 3 comments

Questions Answers
Description? Added position field to feature value table in 9.0.0. Part of PrestaShop/PrestaShop#37042
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? part of PrestaShop/PrestaShop#35499 and PrestaShop/PrestaShop#32267
Sponsor company -
How to test? After upgrading to 9.0.0, feature value table should have position field.

ks129 avatar Sep 27 '24 18:09 ks129

Hello @ks129!

This is your first pull request on autoupgrade repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

ps-jarvis avatar Sep 27 '24 18:09 ps-jarvis

Thank you for your contribution! I have blocked the PR while the PR relating to it is merged on the Core. Do not hesitate to ping me if it is merged and I have not reacted in the meantime.

ga-devfront avatar Sep 30 '24 08:09 ga-devfront

Hi @ks129, Can you please rebase this PR so we can proceed with the review? Thanks

Quetzacoalt91 avatar Nov 14 '24 09:11 Quetzacoalt91

@Quetzacoalt91 I already rebased it today.

ks129 avatar Nov 14 '24 09:11 ks129

Indeed! Sorry for that, I checked the backlog of PRs yesterday and only remembered this morning that I did not post here.

Quetzacoalt91 avatar Nov 14 '24 09:11 Quetzacoalt91

Thanks @ks129

Quetzacoalt91 avatar Nov 14 '24 15:11 Quetzacoalt91

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

ps-jarvis avatar Nov 14 '24 15:11 ps-jarvis