PrestaShop icon indicating copy to clipboard operation
PrestaShop copied to clipboard

Improve wording of pack quantities

Open Hlavtox opened this issue 2 years ago • 4 comments

Questions Answers
Branch? 8.1.x
Description? Improves the wording of pack behavior management. Sometimes even we struggle to see what the options mean.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test?
UI Tests
Fixed issue or discussion?
Related PRs
Sponsor company

Hlavtox avatar Feb 21 '24 09:02 Hlavtox

Ping @kpodemski @MatShir @Julievrz

Hlavtox avatar Feb 21 '24 09:02 Hlavtox

Hi @Hlavtox What do you think of taking inspiration from the "When out of stock" section just below on the page?

Here's an example:

Screenshot 2024-02-23 at 10 33 28

Also, what do you think of adding the "Edit default behavior" link in this section too?

Julievrz avatar Feb 23 '24 09:02 Julievrz

@Julievrz Yes, we could add the link. But I wanted to specifically name it "stock behavior" or "how to calculate stock", because right now it just says how the quantity will be decreased, but it ALSO/MAINLY means HOW the stock is calculated in the first place.

This configuration value means both:

  • How the quantity is calculated.
  • What will be decreased after order.

Full explanation here: https://github.com/PrestaShop/PrestaShop/issues/35367#issuecomment-1956145179

Hlavtox avatar Feb 23 '24 09:02 Hlavtox

@Julievrz Yes, we could add the link. But I wanted to specifically name it "stock behavior" or "how to calculate stock", because right now it just says how the quantity will be decreased, but it ALSO/MAINLY means HOW the stock is calculated in the first place.

This configuration value means both:

  • How the quantity is calculated.
  • What will be decreased after order.

Full explanation here: #35367 (comment)

Thanks, it's way clearer with the full explanation. :)

Julievrz avatar Feb 23 '24 10:02 Julievrz

@Julievrz Wording applied. I also added the link to edit default settings, that's a good idea. :-)

Snímek obrazovky 2024-03-05 105758

Hlavtox avatar Mar 05 '24 09:03 Hlavtox

Auto test - https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/8154574648

Hlavtox avatar Mar 05 '24 10:03 Hlavtox

New run https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/8186337386

Hlavtox avatar Mar 07 '24 10:03 Hlavtox

@kpodemski All green, can we merge?

Hlavtox avatar Mar 07 '24 11:03 Hlavtox

Ping @kpodemski @boherm for re-review 🙏

Hlavtox avatar Apr 02 '24 09:04 Hlavtox