PrestaShop icon indicating copy to clipboard operation
PrestaShop copied to clipboard

Autoupgrade : when module is outdated, link to update the module is badly displayed

Open matks opened this issue 2 years ago • 5 comments

Prerequisites

Describe the bug and add attachments

When the module autoupgrade checks its own version and finds out it is not the latest version, a warning message is displayed and it contains a bad link: Capture d’écran 2023-09-08 à 22 22 22

This happens on PrestaShop 9.0.0 (develop branch).

Expected behavior

The warning message link should be displayed correctly.

Steps to reproduce

  1. Install a 9.0.0 shop (develop branch)
  2. Install module autoupgrade 4.16.1
  3. Click on "Configure" module autoupgrade on backoffice page "Module Manager"
  4. See the warning

The bug can only be seen on an old autoupgrade version because the warning message is displayed when user uses an old version. So the bug cannot be seen on autoupgrade 4.16.3 .

PrestaShop version(s) where the bug happened

9.0.0

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

autoupgrade 4.16.1

Your company or customer's name goes here (if applicable).

No response

matks avatar Sep 08 '23 20:09 matks

I submitted a PR https://github.com/PrestaShop/autoupgrade/pull/625

matks avatar Sep 08 '23 20:09 matks

Duplicate of #33740

sallemiines avatar Sep 11 '23 10:09 sallemiines

Hello @matks

I reproduce the issue with 8.1.x and develop with v4.16.1. Thanks for your PR :rocket:

Thanks!

sallemiines avatar Sep 11 '23 10:09 sallemiines

Duplicate of #33740

Indeed 😄 nice catch

matks avatar Sep 14 '23 19:09 matks

Posting here as https://github.com/PrestaShop/autoupgrade/pull/625 is closed

It may be better to stop displaying the breadcrumbs in the text actually. It would solve this character issue, plus it is not always accurate as some versions of PrestShop had this page named differently (i.e Updates was called Notifications).

Quetzacoalt91 avatar Apr 18 '24 13:04 Quetzacoalt91