PrestaShop icon indicating copy to clipboard operation
PrestaShop copied to clipboard

Published 20 hours ago • verified publisher icon PrestaShop

Fixed installation screen when some config keys were missing

Open nicosomb opened this issue 1 year ago • 5 comments

Questions Answers
Branch? 8.0.x
Description? If some configuration keys are missing in the theme.yaml, the display was buggy.
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? Fixes https://github.com/PrestaShop/PrestaShop/issues/28649
Related PRs
How to test? See https://github.com/PrestaShop/PrestaShop/issues/28649
Possible impacts?

Before

171445162-6430c57d-362b-4be7-93d7-6b47cbfd10db

After

Capture d’écran 2022-09-12 à 10 59 19

nicosomb avatar Sep 12 '22 09:09 nicosomb

Hello @nicosomb!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

prestonBot avatar Sep 12 '22 09:09 prestonBot

Looks like your PR breaks unit tests in tests/Unit/Core/Theme/ConfigReaderTest.php

matthieu-rolland avatar Sep 12 '22 14:09 matthieu-rolland

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

prestonBot avatar Sep 22 '22 08:09 prestonBot

Thank you @nicosomb

matks avatar Sep 22 '22 12:09 matks

FYI, I changed the destination branch to target 8.0.x.

@matks Could you relaunch the QA process please?

nicosomb avatar Sep 23 '22 06:09 nicosomb

Thank you @nicosomb

matks avatar Oct 19 '22 07:10 matks