PrestaShop
PrestaShop copied to clipboard
BO - Modules - Bad display of the title after resizing the screen
Questions | Answers |
---|---|
Branch? | 8.0.x |
Description? | With this pull request we change the .toolbar_btn padding from 16px to 13px. This change is not noticeable on large screens, but on small screens it is just enough for the buttons to be displayed correctly. |
Type? | bug fix |
Category? | BO |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes https://github.com/PrestaShop/PrestaShop/issues/26618 |
How to test? | GO to BO>Modules>Module manager then click in Configure ps_customtext module or other module like payments by check and then Resize the screen to 425x878 |
Before
After
Hello @AlexTechDev!
This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!
@AlexTechDev As this is a regression from 1.7.8, we should fix it on 1.7.8.x
branch
Also, what happens if a module is hooked into these buttons? I guess it would break, maybe we could fine a better solution in order to rework this
Hi @NeOMakinG, I try it on 1.7.8 branch and the same change fix it on these branch. About a module that hook here I don't test it, I can try to hook one module (or maybe we have one example module doing this) and try to solve it.
Hi @NeOMakinG, I try it on 1.7.8 branch and the same change fix it on these branch. About a module that hook here I don't test it, I can try to hook one module (or maybe we have one example module doing this) and try to solve it.
Then, go for a fix on 1.7.8.x
!
Yep we should try with a hooked module, and find a solution working in most of use case we can :)
I don't know any particular modules hooking there, I know ps_mbo
is hooked there for example but this is really specific and not working on 1.7.8.x but more on 8.x, I guess if we want to test this, we will need to develop our own module, or just inject some buttons inside devtools directly, that would do the job as a monkey patch!
Thank you @NeOMakinG and thank you @kpodemski for reminding me of this!
i will inject some buttons inside devtools directly and try it :)
Hi @AlexTechDev
I know you're enjoying new adventures now, so I close this PR! Thanks for contributing anyway!