PrestaShop icon indicating copy to clipboard operation
PrestaShop copied to clipboard

Remove default meta description

Open jf-viguier opened this issue 2 years ago • 9 comments

Questions Answers
Branch? develop
Description? Remove default meta description "Shop powered by PrestaShop", and improve prestashop beginner seo
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes https://github.com/PrestaShop/PrestaShop/issues/28941
How to test? Install prestashop, see that the meta description is not here anymore
Possible impacts? none

jf-viguier avatar Jul 04 '22 08:07 jf-viguier

Hi @jf-viguier, nice PR!

I think you can also remove this wording here: https://github.com/PrestaShop/PrestaShop/blob/6f8365ebba40b37e611525597ea0d3f2c907dc76/classes/lang/KeysReference/MetaLang.php#L57

micka-fdz avatar Jul 04 '22 11:07 micka-fdz

@florine2623

I don't think it's related. We need to export .xlf files for a new release, and then it should be all good.

kpodemski avatar Jul 29 '22 22:07 kpodemski

@jf-viguier could you rebase your PR? :)

kpodemski avatar Jul 29 '22 22:07 kpodemski

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

(Note: this is an automated message, but answering it will reach a real human)

prestonBot avatar Sep 01 '22 10:09 prestonBot

@kpodemski rebase done

jf-viguier avatar Sep 01 '22 10:09 jf-viguier

@matks rebase done

jf-viguier avatar Sep 14 '22 14:09 jf-viguier

Closed/reopened to trigger the CI

atomiix avatar Sep 21 '22 15:09 atomiix

I think @micka-fdz's comment is not here anymore?

Hi @jf-viguier, nice PR!

I think you can also remove this wording here:

https://github.com/PrestaShop/PrestaShop/blob/6f8365ebba40b37e611525597ea0d3f2c907dc76/classes/lang/KeysReference/MetaLang.php#L57

atomiix avatar Sep 21 '22 15:09 atomiix

@atomiix it's done

jf-viguier avatar Sep 22 '22 16:09 jf-viguier

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

prestonBot avatar Sep 26 '22 09:09 prestonBot

Thanks @jf-viguier

atomiix avatar Sep 26 '22 10:09 atomiix