PrestaShop-webservice-lib icon indicating copy to clipboard operation
PrestaShop-webservice-lib copied to clipboard

Improve security for lib_xml

Open mdeweerd opened this issue 2 years ago • 1 comments

Questions Answers
Description? Security fix for libxml. Call libxml_disable_entity_loader(true) and add LIBXML_NONET option for simplexml_load_string.
Type? security fix
BC breaks? no
Deprecations? yes - libxml_disable_entity_loader not supported in reent PHP8.x - but protected with LIBXML_VERSION test
Fixed ticket? None
Sponsor company Applied in Dolibarr (not specifically sponsor company).
How to test? Test multiple PHP versions, regression test.

mdeweerd avatar Dec 22 '23 11:12 mdeweerd

Hi @mdeweerd

Thank for your PR, This PR is too technical for me, ping @PrestaShop/tech-council, can someone please test this PR ?

Thanks

AureRita avatar Feb 05 '24 14:02 AureRita

Thank you @mdeweerd and sorry for late merge

matks avatar Jun 22 '24 19:06 matks