PrestaShop-webservice-lib icon indicating copy to clipboard operation
PrestaShop-webservice-lib copied to clipboard

Published 20 hours ago • verified publisher icon PrestaShop

Exposed error code and message

Open angelo983 opened this issue 2 years ago • 2 comments

  • Exposed error code and message in Exception response
  • Added comments to curl params: CURLOPT_SSL_VERIFYPEER CURLOPT_CAINFO CURLOPT_CAPATH to remind ssl certificate chain checking.
Questions Answers
Description? Please be specific when describing the PR. Every detail helps: What are you changing? Why?
Type? bug fix / improvement / new feature / refacto / critical
BC breaks? yes / no
Deprecations? yes / no
Fixed ticket? Fixes {paste the issue here}.
How to test? Please indicate how to best verify that this PR is correct.
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

angelo983 avatar Apr 28 '22 17:04 angelo983

Hi @angelo983 plenty of maintainers are enjoying some time off this week and the rest of us try to focus on the critical stuff 😅 so review might come a little late

matks avatar May 11 '22 11:05 matks

hi @angelo983, thanks for your contribution. Would you mind filling the PR description table and maybe create an issue with a bit more detail about what your PR aims to do? It would be easier for us to understand and review your code as well as the QA team to check that everything works as expected.

Thanks

atomiix avatar Jun 24 '22 13:06 atomiix

Hello everyone, unfortunately there has been no news from you for more than 3 months, I will follow our guidelines and I'll close this pull request as it seems stale 😞 .

Feel free to ping me to reopen 😉

Thanks!

matks avatar Sep 30 '22 09:09 matks

@matks PR description table just filled

angelo983 avatar Oct 24 '22 07:10 angelo983

@matks I pinged you. I'm a little disappointed of how you value contributions. Guidelines say "may" and not "must" close pull requests after 30 days of inactivity. I do not understand your concern to close, since I too had waited two months for a first feedback.

angelo983 avatar Nov 08 '22 18:11 angelo983

@matks I pinged you. I'm a little disappointed of how you value contributions. Guidelines say "may" and not "must" close pull requests after 30 days of inactivity. I do not understand your concern to close, since I too had waited two months for a first feedback.

@angelo983 I was on holidays when you pinged me and I just got back 😄 this is why I did not answer. I think you can understand people need some vacations sometimes 😄 .

Thank you for filling the description table and as I said i can now reopen 😉

matks avatar Nov 09 '22 09:11 matks

Hello @angelo983 thank you the PR is valid and I tested it

matks avatar Nov 18 '22 10:11 matks