premierlangage icon indicating copy to clipboard operation
premierlangage copied to clipboard

[BUG] Same file in different split spaces are closed together in the editor

Open fwjmath opened this issue 4 years ago • 2 comments

Reproduction Steps to reproduce:

  1. Open some file in the editor.
  2. Press Ctrl-rightarrow. If Issue PremierLangage/platon-front#62 is not fixed, then it should split the current editing space into two halves, each containing the same file.
  3. Close the file on either side.

Expected Behavior It should only close one copy of the file, leaving the other open.

Actual Behavior The other one is also closed.

Comments This behavior is not intuitive, as we expect different editing spaces to act independently.

fwjmath avatar Nov 11 '20 13:11 fwjmath

Sorry but this repository is linked to the next major version (1.0.0) of platform, the issue you are describing here is related to the editor of the current version. All the issues related to the current version (0.7.4) should be created on the repository https://github.com/PremierLangage/premierlangage.

In any case I will move this issue to the right repository now and close it once the issue will be resolved.

mciissee avatar Nov 11 '20 13:11 mciissee

This lines in EditorGroup.close look suspicious as it requests the editor to close all occurrences of the resource.

https://github.com/PremierLangage/premierlangage/blob/1f20333ed4c8d93bf49f4ba330b37b492e19360d/frontend/editor/src/app/pages/editor/shared/models/editor-groups.model.ts#L277-L278

nheir avatar Nov 06 '22 10:11 nheir