ui icon indicating copy to clipboard operation
ui copied to clipboard

BUG: Changing default params is not reflected in already planned schedules

Open MrJack91 opened this issue 3 years ago • 1 comments

Bug Description If we change a default param in the UI, it's not updated for the already scheduled runs, even it's also visible in the schedules -> parameters dialog. This can lead easily to wrongly configured flows which can damage a production environment.

Steps To Reproduce

  1. Setup a simple flow with a parameter.
  2. Setup the schedule -> you will see the yellow bars for the planned runs.
    • if you look there at the "run -> params" you will see there the default param
  3. Change the value of the parameters in "settings -> parameters -> default parameters -> set params"
  4. Checkup configuration in the scheduled runs. It still contains the old params.
  5. If you replan the schedule they will be updated.

Browsers Tested:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

Notes Open a scheduled run
2022-04-29_09h43_45

List params
2022-04-29_09h43_57

Change default value for the full flow
2022-04-29_09h44_16

In the "settings -> schedule-dialog" it displays the correct paramater value

  • (you need a reload of the page)*
    2022-04-29_09h44_47

If we open the scheduled run again, it is still the old parameter value
2022-04-29_09h45_12

MrJack91 avatar Apr 29 '22 07:04 MrJack91

Thanks for the ticket @MrJack91 - as parameters are set at run creation (i.e. when a run is scheduled) this is part of the 1.0 design. You are correcting that toggling the schedule on and then off correctly resets parameters as it creates new runs. An update to the design could help make this more clear and such an issue is one that factors into planning for 2.0

zhen0 avatar May 03 '22 20:05 zhen0