prefect icon indicating copy to clipboard operation
prefect copied to clipboard

fix: few performance improvements

Open fatih-acar opened this issue 7 months ago • 4 comments

Checklist

  • [ ] This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • [ ] If this pull request adds new functionality, it includes unit tests that cover the changes
  • [ ] If this pull request removes docs files, it includes redirect settings in mint.json.
  • [ ] If this pull request adds functions or classes, it includes helpful docstrings.

fatih-acar avatar May 21 '25 19:05 fatih-acar

CodSpeed Performance Report

Merging #18136 will not alter performance

Comparing fatih-acar:fac-perf-improvements (1e1c7fd) with main (0107f74)

Summary

✅ 2 untouched benchmarks

codspeed-hq[bot] avatar May 21 '25 19:05 codspeed-hq[bot]

superseded, see: https://github.com/PrefectHQ/prefect/discussions/18150

zzstoatzz avatar Jun 04 '25 16:06 zzstoatzz

Hi @zzstoatzz I think you meant to close this PR instead: https://github.com/PrefectHQ/prefect/pull/18135

For this one, the changes are still valable but I just don't have time to run benchmarks for this, yet...

fatih-acar avatar Jun 04 '25 16:06 fatih-acar

oof you are totally right - thank you!

zzstoatzz avatar Jun 04 '25 16:06 zzstoatzz

superseded by https://github.com/PrefectHQ/prefect/pull/18314 (for real this time 😅 )

zzstoatzz avatar Jun 16 '25 19:06 zzstoatzz